Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nit. They are words (adverbs), but they don't work so well here. #187

Closed
wants to merge 1 commit into from
Closed

Nit. They are words (adverbs), but they don't work so well here. #187

wants to merge 1 commit into from

Conversation

marcgel
Copy link
Contributor

@marcgel marcgel commented Sep 5, 2014

No description provided.

@rakyll
Copy link
Contributor

rakyll commented Sep 5, 2014

Lint the code. npm run lint. Lint is failing with lib/datastore/query.js: line 130, col 84, Line is too long.

@stephenplusplus
Copy link
Contributor

Merged via 3c875a9.

@sofisl sofisl mentioned this pull request Sep 15, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Sep 15, 2022
@bcoe @callmehiphop
build: switch to GitHub magic proxy (#187)
87965f5
@sofisl sofisl mentioned this pull request Sep 16, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 16, 2022
@yoshi-automation @JustinBeckwith
build: only pipe to codecov if tests run on Node 10 (#187)
8401659
sofisl pushed a commit that referenced this pull request Oct 5, 2022
@yoshi-automation @JustinBeckwith
build: only pipe to codecov if tests run on Node 10 (#187)
ebfbda8
@sofisl sofisl mentioned this pull request Oct 5, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Oct 5, 2022
@yoshi-automation @JustinBeckwith
build: only pipe to codecov if tests run on Node 10 (#187)
30991ec
@sofisl sofisl mentioned this pull request Oct 8, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Oct 8, 2022
@yoshi-automation @JustinBeckwith
build: only pipe to codecov if tests run on Node 10 (#187)
48f3f00
This was referenced Oct 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@jkwlui
build: check broken links in generated docs (#187)
1ed95f8 
* build: check dead links on Kokoro

* recursive crawl local links
sofisl pushed a commit that referenced this pull request Oct 12, 2022
@jmdobry
Refactor old BigQuery samples and add new ones. (#187)
d6d5fba
sofisl pushed a commit that referenced this pull request Oct 12, 2022
@JustinBeckwith @jkwlui
Release v0.9.1 (#187)
4f569c1
@sofisl sofisl mentioned this pull request Oct 12, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@jkwlui @sofisl
build: check broken links in generated docs (#187)
f5a97a7 
* build: check dead links on Kokoro

* recursive crawl local links
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@jkwlui
Release v2.1.3 (#187)
d8a1eca
This was referenced Nov 10, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@renovate @callmehiphop
fix(deps): update dependency yargs to v13 (#187)
890a042
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@JustinBeckwith @yoshi-automation
refactor: use execSync for tests
d2e60d6 
refactor: use execSync for tests

#187 automerged by dpebot
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation @bcoe
chore: regenerate synth.metadata (#187)
4428600
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation
docs: add link to CHANGELOG in README (#187)
86ed40c
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation
feat: move ts target to es2018 from es2016 (#187)
e317a96 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/9b55eba7-85ee-48d5-a737-8b677439db4d/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@1c92077
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot
feat: support regapic LRO (#187)
30152ab 
Use gapic-generator-typescript v2.15.1.
PiperOrigin-RevId: 456946341
Source-Link: googleapis/googleapis@88fd18d
Source-Link: googleapis/googleapis-gen@accfa37
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWNjZmEzNzFmNjY3NDM5MzEzMzM1YzY0MDQyYjA2M2MxYzUzMTAyZSJ9
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore(main): release 2.2.0 (#188)
2211790 
🤖 I have created a release *beep* *boop*
---


## [2.2.0](googleapis/nodejs-video-transcoder@v2.1.0...v2.2.0) (2022-06-29)


### Features

* support regapic LRO ([#187](googleapis/nodejs-video-transcoder#187)) ([7924434](googleapis/nodejs-video-transcoder@7924434))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot
feat: support regapic LRO (#187)
07ad7e5 
* feat: support regapic LRO

Use gapic-generator-typescript v2.15.1.

PiperOrigin-RevId: 456946341

Source-Link: googleapis/googleapis@88fd18d

Source-Link: googleapis/googleapis-gen@accfa37
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWNjZmEzNzFmNjY3NDM5MzEzMzM1YzY0MDQyYjA2M2MxYzUzMTAyZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore(main): release 4.1.0 (#188)
16fceb4 
🤖 I have created a release *beep* *boop*
---


## [4.1.0](googleapis/nodejs-security-private-ca@v4.0.0...v4.1.0) (2022-06-30)


### Features

* support regapic LRO ([#187](googleapis/nodejs-security-private-ca#187)) ([2b2f553](googleapis/nodejs-security-private-ca@2b2f553))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot
feat: add new analysis status and cvss version fields (#187)
aaa30cd 
* feat: add new analysis status and cvss version fields

PiperOrigin-RevId: 477815955

Source-Link: googleapis/googleapis@57e38f0

Source-Link: googleapis/googleapis-gen@3a587e1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2E1ODdlMTQ3NTIxZmY5NGM2OGE3OTE2M2FhMTY4NTVkYjlhN2E4YyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore(main): release 2.1.0 (#173)
52c8f1c 
🤖 I have created a release *beep* *boop*
---


## [2.1.0](https://togithub.com/googleapis/nodejs-binary-authorization/compare/v2.0.0...v2.1.0) (2022-10-06)


### Features

* Add new analysis status and cvss version fields ([#187](https://togithub.com/googleapis/nodejs-binary-authorization/issues/187)) ([d461de8](https://togithub.com/googleapis/nodejs-binary-authorization/commit/d461de86c3abc5db180ae32ea4e6063f3c00df25))


### Bug Fixes

* Allow passing gax instance to client constructor ([#177](https://togithub.com/googleapis/nodejs-binary-authorization/issues/177)) ([6ef4a52](https://togithub.com/googleapis/nodejs-binary-authorization/commit/6ef4a520c1bb49fca8159324dbf41af10931357e))
* Better support for fallback mode ([#170](https://togithub.com/googleapis/nodejs-binary-authorization/issues/170)) ([fa2e0b5](https://togithub.com/googleapis/nodejs-binary-authorization/commit/fa2e0b5991a80e912c65f896bdc0c2670b2a349d))
* Change import long to require ([#172](https://togithub.com/googleapis/nodejs-binary-authorization/issues/172)) ([6327374](https://togithub.com/googleapis/nodejs-binary-authorization/commit/6327374ea12b05cc4d752b059e4d9a098174f45b))
* Do not import the whole google-gax from proto JS ([#1553](https://togithub.com/googleapis/nodejs-binary-authorization/issues/1553)) ([#176](https://togithub.com/googleapis/nodejs-binary-authorization/issues/176)) ([1a53ab4](https://togithub.com/googleapis/nodejs-binary-authorization/commit/1a53ab4d1bb04f4759494973a3297c3dcf295833))
* Preserve default values in x-goog-request-params header ([#180](https://togithub.com/googleapis/nodejs-binary-authorization/issues/180)) ([80b0dcf](https://togithub.com/googleapis/nodejs-binary-authorization/commit/80b0dcf989b20f874e0912af641fdc12419887f2))
* Remove pip install statements ([#1546](https://togithub.com/googleapis/nodejs-binary-authorization/issues/1546)) ([#175](https://togithub.com/googleapis/nodejs-binary-authorization/issues/175)) ([f412b6e](https://togithub.com/googleapis/nodejs-binary-authorization/commit/f412b6e8349aab08d3d5d985cd38f91750c1f030))
* use google-gax v3.3.0 ([1a53ab4](https://togithub.com/googleapis/nodejs-binary-authorization/commit/1a53ab4d1bb04f4759494973a3297c3dcf295833))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot
feat!: remove WebDataStream, IosAppDataStream, `AndroidAppDataStr…
07014d1 
…eam` resources (#187)

* feat!: remove `WebDataStream`, `IosAppDataStream`, `AndroidAppDataStream` resources
and corresponding operations, as they are replaced by the `DataStream` resource
feat: add `restricted_metric_type` field to the `CustomMetric` resource
feat!: move the `GlobalSiteTag` resource from the property level to the data stream level

PiperOrigin-RevId: 432342398

Source-Link: googleapis/googleapis@a079cb0

Source-Link: googleapis/googleapis-gen@2f29c5a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmYyOWM1YWYzMDU0YTZlMzhkZjIxNThmMDliNzZlYzJmYWZkMGIyZiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation @JustinBeckwith
chore: release 1.3.0 (#187)
ebb3797 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
sofisl pushed a commit that referenced this pull request Nov 16, 2022
@yoshi-automation
build: typeo in nodejs .gitattribute (#187)
89755ec 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/cc99acfa-05b8-434b-9500-2f6faf2eaa02/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@799d8e6
This was referenced Nov 16, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 16, 2022
@gcf-owl-bot
fix: better support for fallback mode (#187)
96601fd 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468790263

Source-Link: googleapis/googleapis@873ab45

Source-Link: googleapis/googleapis-gen@cb6f37a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9

chore: deprecate the AwsCrossAccountRole property
feat: add Azure Properties to Connection

Azure properties are used by BigQuery Omni in Azure regions.

PiperOrigin-RevId: 464570667

Source-Link: googleapis/googleapis@75905af

Source-Link: googleapis/googleapis-gen@8c3a248
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGMzYTI0ODViYjM1MDEyZWNiN2EyY2VkMGY5NGExMWQyZGUyNTNiMiJ9

feat: Add service_account_id output field to CloudSQL properties
Clients can now observe the Service Account that is being used when connecting to the CloudSQL from the BigQuery.

PiperOrigin-RevId: 463445598

Source-Link: googleapis/googleapis@fe833dd

Source-Link: googleapis/googleapis-gen@73fad9a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzNmYWQ5YTY1MDIyMjVmYzY0MzMyYjJmNmZlYTgwODljZGE2ZGI1NSJ9
@sofisl sofisl mentioned this pull request Nov 18, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 18, 2022
@JustinBeckwith @bcoe
refactor: use explicit mocha imports (#187)
c93d0b9
@sofisl sofisl mentioned this pull request Nov 30, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 30, 2022
@yoshi-automation
build: missing closing paren in publish script (#187)
5c23dcd
@sofisl sofisl mentioned this pull request Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 10, 2023
@JustinBeckwith
build: fix the lint rules (#187)
af715b2
@sofisl sofisl mentioned this pull request Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 17, 2023
@JustinBeckwith
Fix the sample tests (#187)
6d795f4
sofisl pushed a commit that referenced this pull request Jan 24, 2023
@JustinBeckwith @alexander-fenster
test: remove appveyor config (#187)
4eaec2e
sofisl pushed a commit that referenced this pull request Jan 25, 2023
@JustinBeckwith @alexander-fenster
test: remove appveyor config (#187)
fcbe5f4
sofisl pushed a commit that referenced this pull request Sep 14, 2023
@jkwlui @JustinBeckwith
fix(docs): place doc comment above the last overload (#187)
c285f8e
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
@takeratta takeratta mentioned this pull request Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcgel @rakyll @stephenplusplus