Refactor out BufferStream #179

ryanseys · 2014-09-05T18:15:52Z

Moved BufferStream to its own common file.

stephenplusplus · 2014-09-05T18:20:54Z

+1. Though, while we're talking about BufferStream, are there any community modules we can use instead? https://github.com/dodo/node-bufferstream or https://github.com/gagle/Node-Streamifier after a quick search.

--edit--
Better yet, I like the sounds of this answer: http://stackoverflow.com/a/16044400/776934

We don't seem to be doing anything special with BufferStream, other than pushing a static buffer object as soon as a read is triggered, then immediately closing the stream.

lib/common/bufferstream.js

+  this.push(null);
+};
+
+module.exports.BufferStream = BufferStream;


ryanseys · 2014-09-05T18:37:37Z

It's not immediately clear from the stack overflow answer you provided but I'm assuming we don't have to push null onto that Transform if we used that? I guess the nice thing about using our implementation is we can just pass it around like any other stream so we could inherit from transform if we wanted to instead of readable. I'm a total stream noob though so I'm more of an observer here than anything 😄

PS fixed the module.exports issue you commented on.

stephenplusplus · 2014-09-06T16:08:18Z

I opened #189 that uses the SO implementation.

stephenplusplus · 2014-09-07T02:06:31Z

Just for clean up, and to avoid overwhelming Burcu, I'll close this as I think we (you and I) both like the passthrough stream better. If not, we can always re-open.

ryanseys · 2014-09-07T02:16:19Z

PassThrough = better.

rakyll · 2014-09-08T23:54:14Z

Yes, this is much better. I haven't investigated my options before writing the BufferStream.

* updated CHANGELOG.md * updated package.json * updated samples/package.json

…andwritten libraries (#179) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 429395631 Source-Link: googleapis/googleapis@84594b3 Source-Link: googleapis/googleapis-gen@ed74f97 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9

* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@types/mocha](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/7.0.2/8.0.0) | --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-web-risk).

@ketanbshah

…API to accept project as source. AnalyzeWorkloadMove now also returns information about org policy differences between the project and target folder (#179) * feat: Updated the method signature of analyzeWorkloadMove for v1beta API to accept project as source. AnalyzeWorkloadMove now also returns information about org policy differences between the project and target folder Committer: @ketanbshah PiperOrigin-RevId: 461626403 Source-Link: googleapis/googleapis@6aee59c Source-Link: googleapis/googleapis-gen@1e4553d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWU0NTUzZDYzZTc5ZWQyNTNkYjExOTc0YmM2Yzc0MDU2N2JjYjAzYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.0.4](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.0.3...v2.0.4) (2020-11-03) ### ⚠ BREAKING CHANGES * The WorkerPool API in the v1 surface has been long deprecated, so it has been deleted from the v1 surface. Alpha WorkerPool customers who want to call the WorkerPool API can use gcloud. ### Features * updated third_party Cloud Build clients with new Build message, fix: revert removal of WorkerPool API ([#166](https://www.github.com/googleapis/nodejs-cloudbuild/issues/166)) ([b8d7a39](https://www.github.com/googleapis/nodejs-cloudbuild/commit/b8d7a395bbcc2f6ff83b798ef678e2f27395802d)) ### Bug Fixes * revert removal of WorkerPool API ([#178](https://www.github.com/googleapis/nodejs-cloudbuild/issues/178)) ([07400cb](https://www.github.com/googleapis/nodejs-cloudbuild/commit/07400cbcb05808762ab3c56c5827607cdefd43c0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

samples: pull in latest typeless bot, clean up some comments Source-Link: https://togithub.com/googleapis/synthtool/commit/0a68e568b6911b60bb6fd452eba4848b176031d8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e

@miraleung

... chore: update gapic-generator-ruby to the latest commit chore: release gapic-generator-typescript 1.5.0 Committer: @miraleung PiperOrigin-RevId: 380641501 Source-Link: googleapis/googleapis@076f7e9 Source-Link: googleapis/googleapis-gen@27e4c88

🤖 I have created a release \*beep\* \*boop\* --- ### [2.5.1](https://www.github.com/googleapis/nodejs-bigquery-storage/compare/v2.5.0...v2.5.1) (2021-06-22) ### Bug Fixes * make request optional in all cases ([#179](https://www.github.com/googleapis/nodejs-bigquery-storage/issues/179)) ([b0beaaa](https://www.github.com/googleapis/nodejs-bigquery-storage/commit/b0beaaa280e7599f75e0a439f4ecd4a9a6c059ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

@summer-ji-eng

- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 424244721 Source-Link: googleapis/googleapis@4b6b01f Source-Link: googleapis/googleapis-gen@8ac83fb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2a81bca4-7abd-4108-ac1f-21340f858709/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@dc9caca

* Speech-GA : speech_transcribe_auto_punctuation speech_transcribe_enhanced_model speech_transcribe_model_selection * Speech-GA : Fixing review issues.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

stephenplusplus reviewed Sep 5, 2014
View reviewed changes

lib/common/bufferstream.js

this.push(null);

};

module.exports.BufferStream = BufferStream;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Factor out BufferStream

8321332

stephenplusplus mentioned this pull request Sep 6, 2014

storage: use passthrough stream for buffers. #189

Merged

stephenplusplus closed this Sep 7, 2014

ryanseys deleted the bufferstream-refactor branch September 7, 2014 02:15

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 15, 2022

chore: release 1.1.0 (#179)

6e5e558

* updated CHANGELOG.md * updated package.json * updated samples/package.json

sofisl pushed a commit that referenced this pull request Sep 27, 2022

chore: update the year in the copyright header (#179)

075a2c7

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 12, 2022

fix(deps): update dependency @google-cloud/promisify to ^0.4.0 (#179)

fb8af73

This was referenced Oct 12, 2022

migrate code from googleapis/nodejs-resource-manager #3402

Merged

migrate code from googleapis/nodejs-memcache #3412

Merged

sofisl pushed a commit that referenced this pull request Nov 9, 2022

chore: update the year in the copyright header (#179)

808862f

This was referenced Nov 9, 2022

migrate code from googleapis/nodejs-video-intelligence #3507

Closed

migrate code from googleapis/nodejs-video-intelligence #3519

Merged

migrate code from googleapis/nodejs-cloud-container #3543

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

docs: make usage of the library more clear (#179)

adb34fb

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-iot #3544

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix(docs): link to reference docs section on googleapis.dev (#179)

06b8e8f

* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-dialogflow #3546

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix(samples): Fixed typo in example (#179)

0304fc4

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-assured-workloads #3565

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-cloudbuild #3566

Merged

migrate code from googleapis/nodejs-video-transcoder #3571

Merged

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-gke-hub #3579

Merged

migrate code from googleapis/nodejs-bigquery-storage #3599

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-analytics-admin #3600

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-dialogflow-cx #3602

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

docs: add filter code sample (#179)

c4a73d8

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-bigquery-connection #3646

Merged

4 tasks

sofisl mentioned this pull request Nov 30, 2022

migrate code from googleapis/nodejs-datacatalog #3689

Merged

4 tasks

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

chore: drop contributors from multiple places (#179)

f464ed6

sofisl pushed a commit that referenced this pull request Jan 24, 2023

Speech GA – auto_punctuation & model selection (#179)

73d322a

* Speech-GA : speech_transcribe_auto_punctuation speech_transcribe_enhanced_model speech_transcribe_model_selection * Speech-GA : Fixing review issues.

sofisl pushed a commit that referenced this pull request Jan 25, 2023

Speech GA – auto_punctuation & model selection (#179)

f291f7e

* Speech-GA : speech_transcribe_auto_punctuation speech_transcribe_enhanced_model speech_transcribe_model_selection * Speech-GA : Fixing review issues.

sofisl pushed a commit that referenced this pull request Jan 26, 2023

chore: release 1.10.0 (#179)

00c3f2e

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

sofisl mentioned this pull request Jan 26, 2023

migrate code from googleapis/nodejs-ai-platform #3892

Merged

4 tasks

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 13, 2023

build: add new kokoro config for coverage and release-please (#179)

087dbb7

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

enterstudio mentioned this pull request Nov 28, 2023

[Snyk] Fix for 8 vulnerabilities enterstudio/google-cloud-node#161

Open

takeratta mentioned this pull request Mar 22, 2024

[Snyk] Security upgrade google-gax from 0.14.5 to 0.16.1 takeratta/google-cloud-node#68

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor out BufferStream #179

Refactor out BufferStream #179

ryanseys commented Sep 5, 2014

stephenplusplus commented Sep 5, 2014

This comment was marked as spam.

This comment was marked as spam.

ryanseys commented Sep 5, 2014

stephenplusplus commented Sep 6, 2014

stephenplusplus commented Sep 7, 2014

ryanseys commented Sep 7, 2014

rakyll commented Sep 8, 2014

Refactor out BufferStream #179

Refactor out BufferStream #179

Conversation

ryanseys commented Sep 5, 2014

stephenplusplus commented Sep 5, 2014

This comment was marked as spam.

This comment was marked as spam.

ryanseys commented Sep 5, 2014

stephenplusplus commented Sep 6, 2014

stephenplusplus commented Sep 7, 2014

ryanseys commented Sep 7, 2014

rakyll commented Sep 8, 2014