translate: api updates #1781

callmehiphop · 2016-11-09T16:59:01Z

The most notable change with this request is that ap keys are no longer required and users can now authenticate in a similar fashion to our other APIs.

TODO

Docs
Unit tests
System tests
Support model parameter - this needs more discussion as it is a beta feature!

callmehiphop · 2016-11-09T18:55:17Z

@stephenplusplus @jgeewax @omaray @bjwatson The thing I'm missing here is the model parameter, my understanding is that it is in beta and users will have to be whitelisted to use it. Do we want to cut a separate release to support this parameter?

It's just a string, so I think we could probably get away with just adding it here and making note that users need to be whitelisted to use it. WDYT?

stephenplusplus · 2016-11-09T19:48:32Z

Can you link to any docs on what the model property is?

callmehiphop · 2016-11-09T19:55:39Z

@stephenplusplus I'm not sure any exists yet :( but it would essentially just be a string that the user supplies.

callmehiphop · 2016-11-09T22:21:59Z

Seeing an e2e failure, not sure if it's an actual error or not.

If we send the word Hello! to be translated into Spanish it comes back as ¡Hola!. (This is expected). However when we send the same text in the form of html <body>Hello!</body> we are returned <body>Hola!</body> (The ¡ is no longer present).

bjwatson · 2016-11-09T22:43:49Z

@callmehiphop I've pinged @akeran to see if he has any thoughts on that behavior.

akeran · 2016-11-09T22:52:35Z

If you set format=html you will get "\u003cbody\u003e ¡Hola! \u003c/body\u003e"
html is the default value for this API, please check that you don't overwrite it to format=text

coveralls · 2016-11-10T02:30:28Z

Coverage remained the same at 100.0% when pulling b1c0d25 on callmehiphop:translate-updates into 116436f on GoogleCloudPlatform:master.

stephenplusplus · 2016-11-10T15:33:57Z

Seeing an e2e failure, not sure if it's an actual error or not.

Which test? should autodetect HTML returns what I would expect:

<body> ¡Hola! </body>

callmehiphop · 2016-11-10T20:35:43Z

@akeran the assertion we made actually included the html tags wrapping the content - however, it would appear the issue I was seeing disappeared at some point in the night!

packages/translate/src/index.js

@@ -312,6 +312,9 @@ Translate.prototype.getLanguages = function(target, callback) {
 *     is written in.
 * @param {string} options.to - The ISO 639-1 language code to translate the
 *     input to.
+ * @param {string} options.model - **Note:** Users must be whitelisted to use


coveralls · 2016-11-11T04:53:12Z

Coverage remained the same at 100.0% when pulling b1d2392 on callmehiphop:translate-updates into 116436f on GoogleCloudPlatform:master.

packages/translate/README.md

+It's also possible to authenticate with an API key. To create an API key:
+
+1. Visit the [Google Developers Console][dev-console].
+2. 2. Create a new project or click on an existing project.


packages/translate/src/index.js

@@ -305,6 +312,9 @@ Translate.prototype.getLanguages = function(target, callback) {
 *     is written in.
 * @param {string} options.to - The ISO 639-1 language code to translate the
 *     input to.
+ * @param {string} options.model - **Note:** Users must be whitelisted to use


packages/translate/system-test/translate.js

-  }
-
-  var translate = new Translate(extend({}, env, { key: API_KEY }));
+describe('translate', function() {


packages/translate/test/index.js

@@ -38,9 +42,16 @@ var fakeUtil = extend({}, util, {
  }
 });

+function FakeService() {
+  this.calledWith_ = arguments;
+  Service.apply(this, arguments);


packages/translate/test/index.js

+      });
+
+      it('should localize the api key', function() {
+        assert.equal(translate.key, KEY_OPTIONS.key);


packages/translate/test/index.js

-      }, /An API key is required to use the Translate API\./);
-    });
+    it('should inherit from Service', function() {
+      assert(translate instanceof Service);


coveralls · 2016-11-11T21:55:59Z

Changes Unknown when pulling 023359d on callmehiphop:translate-updates into * on GoogleCloudPlatform:master*.

packages/translate/src/index.js

+    baseUrl: baseUrl,
+    scopes: ['https://www.googleapis.com/auth/cloud-platform'],
+    packageJson: require('../package.json'),
+    projectIdRequired: false


packages/translate/src/index.js

@@ -303,6 +310,9 @@ Translate.prototype.getLanguages = function(target, callback) {
 *     not, we set the format as `text`.
 * @param {string} options.from - The ISO 639-1 language code the source input
 *     is written in.
+ * @param {string} options.model - **Note:** Users must be whitelisted to use
+ *     this parameter. Set the model type requested for this translation. Please
+ *     refer to the upstread documentation for possible values.


packages/translate/src/index.js

@@ -381,16 +391,20 @@ Translate.prototype.translate = function(input, options, callback) {
    if (options.to) {
      query.target = options.to;
    }
+
+    if (options.model) {
+      query.model = options.model;


packages/translate/test/index.js

-        a: 'b',
-        c: 'd',
-        qs: {
+      beforeEach(function() {


coveralls · 2016-11-12T02:17:01Z

Changes Unknown when pulling b68c187 on callmehiphop:translate-updates into * on GoogleCloudPlatform:master*.

stephenplusplus · 2016-11-14T15:45:22Z

Please re-assign if it needs another look.

callmehiphop added don't merge api: translate Issues related to the Cloud Translation API. labels Nov 9, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2016

callmehiphop commented Nov 10, 2016

View reviewed changes

callmehiphop assigned stephenplusplus Nov 10, 2016

stephenplusplus suggested changes Nov 11, 2016

View reviewed changes

callmehiphop added 4 commits November 11, 2016 12:30

translate: api updates

b38797a

tests + docs

d46519b

add support for model parameter

15a1262

minor tweaks from PR feedback

023359d

stephenplusplus reviewed Nov 11, 2016

View reviewed changes

minor fixes per PR feedback

b68c187

stephenplusplus removed their assignment Nov 14, 2016

stephenplusplus removed the don't merge label Nov 14, 2016

stephenplusplus merged commit 6e9ae57 into googleapis:master Nov 14, 2016

sofisl pushed a commit that referenced this pull request Nov 10, 2022

translate: api updates (#1781)

8f0987d

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-translate #3520

Merged

4 tasks

translate: api updates #1781

translate: api updates #1781

Conversation

callmehiphop commented Nov 9, 2016 • edited Loading

TODO

callmehiphop commented Nov 9, 2016 • edited Loading

stephenplusplus commented Nov 9, 2016

callmehiphop commented Nov 9, 2016

callmehiphop commented Nov 9, 2016

bjwatson commented Nov 9, 2016

akeran commented Nov 9, 2016

coveralls commented Nov 10, 2016

stephenplusplus commented Nov 10, 2016

callmehiphop commented Nov 10, 2016

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 11, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 11, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 12, 2016

stephenplusplus commented Nov 14, 2016

callmehiphop commented Nov 9, 2016 •

edited

Loading

callmehiphop commented Nov 9, 2016 •

edited

Loading