Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring: add to google-cloud #1740

Merged

Conversation

stephenplusplus
Copy link
Contributor

No description provided.

@stephenplusplus stephenplusplus added the api: monitoring Issues related to the Cloud Monitoring API. label Oct 21, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2016
@stephenplusplus stephenplusplus added the status: blocked Resolving the issue is dependent on other work. label Oct 21, 2016
@stephenplusplus
Copy link
Contributor Author

@landrito @jmuk we're getting an error trying to use the generated API:

https://github.com/GoogleCloudPlatform/google-cloud-node/blob/97207ec97bea51bfc9049c6a818a6ee7338bdadf/packages/monitoring/src/v3/group_service_api.js#L524

var groupServiceClient = require('grpc-google-monitoring-v3').client;

grpc-google-monitoring-v3 doesn't exist on npm and isn't a dependency. Is this a typo?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7d6d122 on stephenplusplus:spp--monitoring-hello into 4a4493a on GoogleCloudPlatform:master.

@landrito
Copy link
Contributor

I suspect that I generated the file with an incorrect package name which caused this error because the gapic-yaml package name is not here. I'll regenerate. Sec

@landrito
Copy link
Contributor

landrito commented Oct 21, 2016

I regenerated at #1741.

@stephenplusplus stephenplusplus removed the status: blocked Resolving the issue is dependent on other work. label Oct 22, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 58e7806 on stephenplusplus:spp--monitoring-hello into f8f713a on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 28247c6 into googleapis:master Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants