Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cloud Functions #1688

Closed
wants to merge 1 commit into from
Closed

Add support for Cloud Functions #1688

wants to merge 1 commit into from

Conversation

jmdobry
Copy link
Contributor

@jmdobry jmdobry commented Oct 13, 2016

  • - GAPIC code
  • - Implementation
    • - Functions#cloudfunction
    • - Functions#createFunction
    • - Functions#getFunctions
    • - Functions#getFunctionsStream
    • - Functions#operation
    • - CloudFunction#call
    • - CloudFunction#create
    • - CloudFunction#delete
    • - CloudFunction#exists
    • - CloudFunction#get
    • - CloudFunction#setMetadata
  • - unit tests
  • - system tests
  • - docs

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2016
@jmdobry jmdobry changed the title Add placeholder Cloud Functions package. [DO NOT MERGE] Add placeholder Cloud Functions package. Oct 13, 2016
@jmdobry jmdobry changed the title [DO NOT MERGE] Add placeholder Cloud Functions package. [DO NOT MERGE] Add support for Cloud Functions Oct 13, 2016
@stephenplusplus stephenplusplus changed the title [DO NOT MERGE] Add support for Cloud Functions Add support for Cloud Functions Oct 14, 2016
@jmdobry
Copy link
Contributor Author

jmdobry commented Dec 21, 2016

@stephenplusplus @callmehiphop

The Cloud Functions API ListFunctions method doesn't support pagination yet. I attempted to use the paginator for the getFunctions method, but limiting doesn't appear work. Here's the skipped test.

The PR is done (except for docs), barring any requested changes during review.

I experimentally implemented this PR using some ES2015 features (see #1855), and set the engines field in package.json to "node": ">=4.3.2" (it's the oldest 4.x version shown at node.green. I imagine the @google-cloud/functions package will be "alpha" for a while, then "beta", and by the time it's GA google-cloud-node will have dropped support for Node.js 0.12, so perhaps it can be a pilot for #1855.

@ofrobots
Copy link
Contributor

ofrobots commented Jan 3, 2017

@jmdobry not sure what view you're seeing, I do see more recent versions of Node.js 4.x on node.green (not that there is a difference in the list of supported language features that I am aware of between 4.3.x and 4.7.x)

@jmdobry
Copy link
Contributor Author

jmdobry commented Jan 3, 2017

I see the more recent 4.x versions too, but I thought it was prudent to stay compatible with older 4.x versions.

@jmdobry
Copy link
Contributor Author

jmdobry commented Jan 13, 2017

Instead of dropping support for 0.10 and 0.12 straight away in google-auth-library-nodejs, perhaps a better experiment would be to drop support for 0.10 and 0.12 in a brand new package, such as this one.

@lukesneeringer lukesneeringer added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Apr 19, 2017
@stephenplusplus
Copy link
Contributor

What's the plan / status of this?

@jmdobry
Copy link
Contributor Author

jmdobry commented Apr 21, 2017

Good question. cc @omaray

Option 1

Continue forward with this PR. There have been many changes to the google-cloud-node common libraries since I submitted this, so it's needs some work to get up-to-date. When I left off the PR was ready for review.

Option 2

Expose the Gapic code to the user and delete the majority of my handwritten code, keeping only the helper function that zips and uploads a directory to Google Cloud Storage in preparation for creating/deploying a new Cloud Function (because it's a beast, and I'd hate to have to make users do all that themselves).

@lukesneeringer
Copy link
Contributor

Instead of dropping support for 0.10 and 0.12 straight away in google-auth-library-nodejs, perhaps a better experiment would be to drop support for 0.10 and 0.12 in a brand new package, such as this one.
👍 1

Worth noting: This has been adjudicated already. 0.12 support is gone.

@lukesneeringer
Copy link
Contributor

Option 1

Continue forward with this PR. There have been many changes to the google-cloud-node common libraries since I submitted this, so it's needs some work to get up-to-date. When I left off the PR was ready for review.

Option 2

Expose the Gapic code to the user and delete the majority of my handwritten code, keeping only the helper function that zips and uploads a directory to Google Cloud Storage in preparation for creating/deploying a new Cloud Function (because it's a beast, and I'd hate to have to make users do all that themselves).

Our team is working on the concept of a "partial GAPIC", which is basically option 2. We should almost certainly do that. I should have a design doc soon and this could be a useful proof case for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants