translate: allow setting format of text #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenplusplus
added
the
api: translate
googlebot
added
the
cla: yes
stephenplusplus
force-pushed
the
spp--1574
branch
from
78e3561
to
aabd9b8
Compare
|
Changes Unknown when pulling aabd9b8 on stephenplusplus:spp--1574 into * on GoogleCloudPlatform:master*. |
callmehiphop
reviewed
Oct 3, 2016
| @@ -268,6 +269,7 @@ Translate.prototype.getLanguages = function(target, callback) { | |||
| * target ISO 639-1 language code to translate the source input to. (e.g. | |||
| * `en` for English). If an object, you may also specify the source | |||
| * language. | |||
| * @param {string} options.format - Set the text's format as `html` or `text`. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@stephenplusplus can we add a system test for this? |
stephenplusplus
force-pushed
the
spp--1574
branch
from
aabd9b8
to
f1ceb22
Compare
|
PTAL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #1574
See #1574 for the discussion of this feature.
@innovative1 thanks for the idea and the original implementation! Can you take a look at this one?