Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speech: fix docs to use correct event #1639

Closed
wants to merge 2 commits into from

Conversation

evancohen
Copy link

@evancohen evancohen commented Sep 28, 2016

After a little bit of head scratching I'm pretty sure that the docs are incorrect. The requestStream emits a 'response' event: index.js#L484

Right now they the docs claim it is 'data'. The event name should either be changed or the docs should be updated to reflect the actual name to prevent further confusion.

Note: this may impact #1631

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 28, 2016
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 28, 2016
@evancohen
Copy link
Author

Nope. Please disregard.

@evancohen evancohen closed this Sep 28, 2016
@evancohen evancohen deleted the patch-1 branch September 28, 2016 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants