Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate: fix system test translation #1482

Merged
merged 1 commit into from
Aug 11, 2016
Merged

translate: fix system test translation #1482

merged 1 commit into from
Aug 11, 2016

Conversation

stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Aug 11, 2016 •
edited
Loading

The translate API must have improved :)

This fixes our system test:

  Uncaught AssertionError: '¿Cómo estás hoy?' === 'Como estas hoy?'
  + expected - actual

  -¿Cómo estás hoy?
  +Como estas hoy?

@stephenplusplus stephenplusplus added the api: translate Issues related to the Cloud Translation API. label Aug 11, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2016
@callmehiphop callmehiphop merged commit 2391762 into googleapis:master Aug 11, 2016
stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this pull request Aug 23, 2016
@stephenplusplus
translate: fix system test translation (googleapis#1482)
ced4026
@mikolajroszak mikolajroszak mentioned this pull request Aug 1, 2022
Open
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@stephenplusplus @callmehiphop
translate: fix system test translation (#1482)
3242903
@sofisl sofisl mentioned this pull request Nov 10, 2022
Merged
4 tasks
@mikolajroszak mikolajroszak mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@callmehiphop callmehiphop

Labels
api: translate Issues related to the Cloud Translation API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenplusplus @callmehiphop @googlebot