-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common/util test coverage is lacking #747
Comments
4 tasks
sofisl
pushed a commit
that referenced
this issue
Sep 27, 2022
* fix: do not import the whole google-gax from proto JS (#1553) fix: use google-gax v3.3.0 Source-Link: googleapis/synthtool@c73d112 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e * fix(deps): update google-gax Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Alexander Fenster <fenster@google.com>
sofisl
pushed a commit
that referenced
this issue
Nov 9, 2022
* fix: do not import the whole google-gax from proto JS (#1553) fix: use google-gax v3.3.0 Source-Link: googleapis/synthtool@c73d112 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e * fix(deps): update google-gax Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Alexander Fenster <fenster@google.com>
This was referenced Nov 9, 2022
Merged
4 tasks
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
sofisl
pushed a commit
that referenced
this issue
Nov 17, 2022
4 tasks
sofisl
pushed a commit
that referenced
this issue
Jan 24, 2023
* chore: update gapic-generator-typescript to v1.3.2 Committer: @alexander-fenster PiperOrigin-RevId: 372656503 Source-Link: googleapis/googleapis@6fa858c Source-Link: googleapis/googleapis-gen@d7c95df * 🦉 Updates from OwlBot Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Jeff Ching <chingor@google.com>
sofisl
pushed a commit
that referenced
this issue
Jan 25, 2023
* chore: update gapic-generator-typescript to v1.3.2 Committer: @alexander-fenster PiperOrigin-RevId: 372656503 Source-Link: googleapis/googleapis@6fa858c Source-Link: googleapis/googleapis-gen@d7c95df * 🦉 Updates from OwlBot Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Jeff Ching <chingor@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Could use a sweep to make sure all functions are covered.
Should wait for #746 before tackling 🏈.
The text was updated successfully, but these errors were encountered: