Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/util test coverage is lacking #747

Closed
stephenplusplus opened this issue Jul 27, 2015 · 0 comments
Closed

common/util test coverage is lacking #747

stephenplusplus opened this issue Jul 27, 2015 · 0 comments
Assignees
@callmehiphop

Comments

@stephenplusplus
Copy link
Contributor

Could use a sweep to make sure all functions are covered.

Should wait for #746 before tackling 🏈.
@callmehiphop callmehiphop self-assigned this Jul 29, 2015
@callmehiphop callmehiphop mentioned this issue Jul 30, 2015
Merged
@sofisl sofisl mentioned this issue Sep 27, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Sep 27, 2022
@gcf-owl-bot @alexander-fenster
fix: do not import the whole google-gax from proto JS (#1553) (#747)
92f89ea 
* fix: do not import the whole google-gax from proto JS (#1553)

fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e

* fix(deps): update google-gax

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Fenster <fenster@google.com>
sofisl pushed a commit that referenced this issue Nov 9, 2022
@gcf-owl-bot @alexander-fenster
fix: do not import the whole google-gax from proto JS (#1553) (#747)
1e9f27c 
* fix: do not import the whole google-gax from proto JS (#1553)

fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e

* fix(deps): update google-gax

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Fenster <fenster@google.com>
This was referenced Nov 9, 2022
Closed
Merged
@release-please release-please bot mentioned this issue Nov 10, 2022
Merged
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
build: update .OwlBot.lock with new version of post-processor (#747)
96ecbd1
sofisl pushed a commit that referenced this issue Nov 17, 2022
@FrodoTheTrue
chore(samples): add moving instances between zones samples (#747)
f260dee
@sofisl sofisl mentioned this issue Nov 17, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 24, 2023
@gcf-owl-bot @chingor13
chore: update gapic-generator-typescript to v1.3.2 (#747)
3b23b13 
* chore: update gapic-generator-typescript to v1.3.2

Committer: @alexander-fenster
PiperOrigin-RevId: 372656503

Source-Link: googleapis/googleapis@6fa858c

Source-Link: googleapis/googleapis-gen@d7c95df

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Jeff Ching <chingor@google.com>
sofisl pushed a commit that referenced this issue Jan 25, 2023
@gcf-owl-bot @chingor13
chore: update gapic-generator-typescript to v1.3.2 (#747)
f148ce3 
* chore: update gapic-generator-typescript to v1.3.2

Committer: @alexander-fenster
PiperOrigin-RevId: 372656503

Source-Link: googleapis/googleapis@6fa858c

Source-Link: googleapis/googleapis-gen@d7c95df

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Jeff Ching <chingor@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@callmehiphop callmehiphop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenplusplus @callmehiphop