-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impossible to upload files to google storage with v0.12.0 #470
Comments
Sorry to hear that! Could you try against the latest code in master. We haven't pushed a new version to npm in a while, so you might have better luck with the most up to date code. Let me know how it goes! |
master or 0.12.0 behave the same.
and
and both have the same issue. |
The |
ok so tried again with the latest master branch and it still has the same issue.
this also:
|
It would be great to see a small sample of code. I'm not sure how this would work in 0.11 and not now, but I'm determined to find the cause! |
What version of node are you running? The stack trace seems to hint at the fact that the error occurs outside the realms of our library. |
im using node v0.10.38 |
ok here it is: https://github.com/aschmid/gcloud.storage.test.git just copy your credentials into this version doesn't work for me, if i change the gcloud version to |
After a quick glance, it looks like you're using the end event. Try hooking On Wednesday, April 1, 2015, andreas schmid notifications@github.com
|
i tried the complete too but still same result |
btw the complete doesnt even work with 0.11.0 |
No problem, I'll take a dive in to the code soon. Thanks for putting the On Wednesday, April 1, 2015, andreas schmid notifications@github.com
|
I changed |
0.12.0 is a thing of the past too :) we just recently launched 0.13.1. That being said, if you still have issues I'd suggest a clean install of node and ensure you're not running behind any proxy server or restrictive firewall that might get in the way of uploading! |
@ryanseys i had to reset my whole computer 2 days ago so my node environment is as clean as it could be :) |
By the looks of the error it's happening at the TLS level so maybe it can't properly negotiate a secure connection. That being said I have no idea why it would work on 0.11 and not 0.13. Funky bug. |
yes it is... in any case i was able to work around it but still very annoying. |
Do you have a patch or is your workaround to just use 0.11? |
no don't have a patch yet. didn't have time to dig into the actual issue so i used 0.11 for the stuff i needed but obviously i would prefer to be up to date. |
would be interesting to know if it is just me or if other ppl have the same issue |
i just noticed |
bucket.upload is a wrapper around createWriteStream, with some defaults set: https://github.com/GoogleCloudPlatform/gcloud-node/blob/master/lib/storage/bucket.js#L776 Maybe try to mimic that set up as close as you can. |
@aschmid going to close as it doesn't seem to be an issue with the library, but something on your end. Feel free to re-open if you can replicate on another machine or provide a test case we can reproduce. |
ok good for now. did anybody of you guys try my code? does it work for you? |
ok guys i found the actual issue. when creating a write stream for the file its absolutely necessary to pass in
if this option is not passed in the |
Any patch? :) |
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/tmp](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`0.2.0` -> `0.2.1`](https://renovatebot.com/diffs/npm/@types%2ftmp/0.2.0/0.2.1) | [![age](https://badges.renovateapi.com/packages/npm/@types%2ftmp/0.2.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2ftmp/0.2.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2ftmp/0.2.1/compatibility-slim/0.2.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2ftmp/0.2.1/confidence-slim/0.2.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-dns).
while 0.11.0 works completely fine i am experiencing huge issues uploading files with the latest (0.12.0) version.
a simple file upload takes forever and might even miss a response.
not sure what changed between the versions but it broke something.
The text was updated successfully, but these errors were encountered: