Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Speech NodeJS veneer: Examples in comments don't illustrate needed parameters #1926

Closed
pbogle opened this issue Jan 18, 2017 · 4 comments · Fixed by #1958
Closed
Assignees
Labels
api: speech Issues related to the Speech-to-Text API.

Comments

@pbogle
Copy link

pbogle commented Jan 18, 2017

The examples in the comments in the NodeJS veneer won't work because they don't include needed parameters: e.g. the {} values in:
https://github.com/GoogleCloudPlatform/google-cloud-node/blob/master/packages/speech/src/v1beta1/speech_client.js#L158

 var client = speechV1beta1.speechClient();
  var config = {};
  var audio = {};
  var request = {
      config: config,
      audio: audio
  };
  client.syncRecognize(request).then(function(responses) {
      var response = responses[0];
      // doThingsWith(response)
  }).catch(function(err) {
      console.error(err);
  });


@angadn
Copy link

angadn commented Jan 19, 2017

+1 This was a major problem for me while implementing Speech APIs also, and I resolved it by reading through source-code. It's typical for an early-stage BETA

@stephenplusplus
Copy link
Contributor

cc: @jmuk @landrito

@jmuk
Copy link
Contributor

jmuk commented Jan 19, 2017

I see. This sample is auto-generated, and it missed to capture patterns like this. I've filed googleapis/gapic-generator#941

@jmuk jmuk self-assigned this Jan 19, 2017
@stephenplusplus
Copy link
Contributor

Thanks, @jmuk!

jmuk added a commit to jmuk/gcloud-node that referenced this issue Feb 2, 2017
This update includes the fixes of initial values in the sample
code, see googleapis#1926
stephenplusplus pushed a commit that referenced this issue Feb 2, 2017
This update includes the fixes of initial values in the sample
code, see #1926
sofisl pushed a commit that referenced this issue Jan 24, 2023
This update includes the fixes of initial values in the sample
code, see #1926
sofisl pushed a commit that referenced this issue Jan 25, 2023
This update includes the fixes of initial values in the sample
code, see #1926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: speech Issues related to the Speech-to-Text API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants