Enable noImplicitThis (#102)

googleapis · Sep 9, 2018 · f43056b · f43056b
1 parent 1783a04
commit f43056b
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 27 deletions.
diff --git a/packages/google-cloud-dns/test/change.ts b/packages/google-cloud-dns/test/change.ts
@@ -20,7 +20,7 @@ import * as assert from 'assert';
 import * as extend from 'extend';
 import * as nodeutil from 'util';
 import * as proxyquire from 'proxyquire';
-import {ServiceObject} from '@google-cloud/common';
+import {ServiceObject, ServiceObjectConfig} from '@google-cloud/common';
 import * as promisify from '@google-cloud/promisify';
 
 let promisified = false;
@@ -33,13 +33,14 @@ const fakePromisify = extend({}, promisify, {
   },
 });
 
-function FakeServiceObject() {
-  this.calledWith_ = arguments;
-  ServiceObject.apply(this, arguments);
+class FakeServiceObject extends ServiceObject {
+  calledWith_: IArguments;
+  constructor(config: ServiceObjectConfig) {
+    super(config);
+    this.calledWith_ = arguments;
+  }
 }
 
-nodeutil.inherits(FakeServiceObject, ServiceObject);
-
 describe('Change', () => {
   // tslint:disable-next-line:variable-name
   let Change;

diff --git a/packages/google-cloud-dns/test/index.ts b/packages/google-cloud-dns/test/index.ts
@@ -21,7 +21,7 @@ import * as assert from 'assert';
 import * as extend from 'extend';
 import * as nodeutil from 'util';
 import * as proxyquire from 'proxyquire';
-import {Service} from '@google-cloud/common';
+import {Service, ServiceConfig, ServiceOptions} from '@google-cloud/common';
 import {util} from '@google-cloud/common';
 import * as promisify from '@google-cloud/promisify';
 
@@ -44,13 +44,14 @@ const fakePaginator = {
   },
 };
 
-function FakeService() {
-  this.calledWith_ = arguments;
-  Service.apply(this, arguments);
+class FakeService extends Service {
+  calledWith_: IArguments;
+  constructor(config: ServiceConfig, options?: ServiceOptions) {
+    super(config, options);
+    this.calledWith_ = arguments;
+  }
 }
 
-nodeutil.inherits(FakeService, Service);
-
 const fakeUtil = extend({}, util, {
   makeAuthenticatedRequestFactory() {},
 });
@@ -68,8 +69,11 @@ const fakePromisify = extend({}, promisify, {
   },
 });
 
-function FakeZone() {
-  this.calledWith_ = arguments;
+class FakeZone {
+  calledWith_: IArguments;
+  constructor() {
+    this.calledWith_ = arguments;
+  }
 }
 
 describe('DNS', () => {

diff --git a/packages/google-cloud-dns/test/zone.ts b/packages/google-cloud-dns/test/zone.ts
@@ -55,12 +55,15 @@ const fakeFs = {
   },
 };
 
-function FakeChange() {
-  this.calledWith_ = arguments;
+class FakeChange {
+  calledWith_: IArguments;
+  constructor() {
+    this.calledWith_ = arguments;
+  }
 }
 
 class FakeRecord {
-  calledWith_;
+  calledWith_: IArguments;
   constructor() {
     this.calledWith_ = arguments;
   }
@@ -357,14 +360,6 @@ describe('Zone', () => {
         zone.delete({force: true}, assert.ifError);
       });
     });
-
-    it.skip('should make the correct API request', done => {
-      FakeServiceObject.prototype.delete = callback => {
-        assert.strictEqual(this, zone);
-        callback!(null);
-      };
-      zone.delete(done);
-    });
   });
 
   describe('deleteRecords', () => {

diff --git a/packages/google-cloud-dns/tsconfig.json b/packages/google-cloud-dns/tsconfig.json
@@ -3,8 +3,7 @@
   "compilerOptions": {
     "rootDir": ".",
     "outDir": "build",
-    "noImplicitAny": false,
-    "noImplicitThis": false
+    "noImplicitAny": false
   },
   "include": [
     "src/*.ts",