Skip to content

Commit

Permalink
fix: dataproc v1 AutoscalingPolicy annotation
Browse files Browse the repository at this point in the history
This PR was generated using Autosynth. 🌈

Commits in this repo since last synth:
776b6f66fa675e56a6350a740b62fa6641bb8273 build: add GitHub actions config for unit tests
0e1a5154605c1a1c741529cb5bfb4c31efef2bce chore: release 1.6.0 (#306)
f03653cee234178b8214562343e54f53bed67034 chore: release 1.6.0 (#303)
2e811f56a173225aa3cbb306e21574fe4c123817 chore(deps): update dependency linkinator to v2 (#305)


<details><summary>Log from Synthtool</summary>

```
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
On branch autosynth
nothing to commit, working tree clean
HEAD detached at FETCH_HEAD
nothing to commit, working tree clean
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:6aec9c34db0e4be221cdaf6faba27bdc07cfea846808b3d3b964dfce3a9a0f9b
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/dataproc/artman_dataproc_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/dataproc-v1.
synthtool > Running generator for google/cloud/dataproc/artman_dataproc_v1beta2.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/dataproc-v1beta2.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.github/PULL_REQUEST_TEMPLATE.md
.github/release-please.yml
.github/workflows/ci.yaml
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node12/common.cfg
.kokoro/continuous/node12/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node12/common.cfg
.kokoro/presubmit/node12/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/docs.cfg
.kokoro/release/docs.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
README.md
codecov.yaml
renovate.json
samples/README.md
synthtool > Replaced 'https:\\/\\/cloud\\.google\\.com[\\s\\*]*\\/compute\\/' in src/v1beta2/doc/google/cloud/dataproc/v1beta2/doc_clusters.js.
synthtool > Replaced '\\[Empty\\]\\(https:\\/\\/cloud\\.google\\.comgoogle\\.protobuf\\.Empty\\)' in src/v1beta2/cluster_controller_client.js.
npm WARN npm npm does not support Node.js v12.16.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> protobufjs@6.8.8 postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.1.1 (node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 511 packages from 803 contributors and audited 1043 packages in 10.782s
found 0 vulnerabilities

npm WARN npm npm does not support Node.js v12.16.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/dataproc@1.6.0 fix /tmpfs/src/git/autosynth/working_repo
> eslint --fix '**/*.js'


/tmpfs/src/git/autosynth/working_repo/samples/createCluster.js
  19:28  error    "@google-cloud/dataproc" is not found  node/no-missing-require
  27:5   warning  Unexpected 'todo' comment              no-warning-comments

/tmpfs/src/git/autosynth/working_repo/samples/quickstart.js
  27:28  error  "@google-cloud/dataproc" is not found  node/no-missing-require
  28:29  error  "@google-cloud/storage" is not found   node/no-missing-require
  30:25  error  "sleep" is not found                   node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/system-test/createCluster.test.js
  17:26  error  "chai" is not found                    node/no-missing-require
  25:26  error  "@google-cloud/dataproc" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/system-test/quickstart.test.js
  17:26  error  "chai" is not found                    node/no-missing-require
  22:26  error  "@google-cloud/dataproc" is not found  node/no-missing-require
  23:27  error  "@google-cloud/storage" is not found   node/no-missing-require

✖ 10 problems (9 errors, 1 warning)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @google-cloud/dataproc@1.6.0 fix: `eslint --fix '**/*.js'`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @google-cloud/dataproc@1.6.0 fix script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2020-02-18T19_05_43_555Z-debug.log
installing semver@^5.5.0
installing minimist@^1.2.0
installing uglify-js@^3.3.25
installing espree@^3.5.4
installing escodegen@^1.9.1
synthtool > Wrote metadata to synth.metadata.

```
</details>
  • Loading branch information
yoshi-automation authored Feb 20, 2020
1 parent 521cc6a commit c1e3253
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ option java_multiple_files = true;
option java_outer_classname = "AutoscalingPoliciesProto";
option java_package = "com.google.cloud.dataproc.v1";

option (google.api.resource_definition) = {
type: "dataproc.googleapis.com/Region"
pattern: "projects/{project}/regions/{region}"
};

// The API interface for managing autoscaling policies in the
// Dataproc API.
service AutoscalingPolicyService {
Expand Down Expand Up @@ -98,6 +103,7 @@ service AutoscalingPolicyService {
message AutoscalingPolicy {
option (google.api.resource) = {
type: "dataproc.googleapis.com/AutoscalingPolicy"
pattern: "projects/{project}/locations/{location}/autoscalingPolicies/{autoscaling_policy}"
pattern: "projects/{project}/regions/{region}/autoscalingPolicies/{autoscaling_policy}"
};

Expand Down
4 changes: 3 additions & 1 deletion packages/google-cloud-dataproc/protos/protos.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
"go_package": "google.golang.org/genproto/googleapis/cloud/dataproc/v1;dataproc",
"java_multiple_files": true,
"java_outer_classname": "WorkflowTemplatesProto",
"java_package": "com.google.cloud.dataproc.v1"
"java_package": "com.google.cloud.dataproc.v1",
"(google.api.resource_definition).type": "dataproc.googleapis.com/Region",
"(google.api.resource_definition).pattern": "projects/{project}/regions/{region}"
},
"nested": {
"AutoscalingPolicyService": {
Expand Down
25 changes: 20 additions & 5 deletions packages/google-cloud-dataproc/synth.metadata
Original file line number Diff line number Diff line change
@@ -1,19 +1,34 @@
{
"updateTime": "2020-02-08T01:13:12.324031Z",
"updateTime": "2020-02-18T19:05:53.930526Z",
"sources": [
{
"generator": {
"name": "artman",
"version": "0.44.4",
"dockerImage": "googleapis/artman@sha256:19e945954fc960a4bdfee6cb34695898ab21a8cf0bac063ee39b91f00a1faec8"
"version": "0.45.0",
"dockerImage": "googleapis/artman@sha256:6aec9c34db0e4be221cdaf6faba27bdc07cfea846808b3d3b964dfce3a9a0f9b"
}
},
{
"git": {
"name": ".",
"remote": "https://github.com/googleapis/nodejs-dataproc.git",
"sha": "776b6f66fa675e56a6350a740b62fa6641bb8273"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "e7d8a694f4559201e6913f6610069cb08b39274e",
"internalRef": "293903652"
"sha": "ab2685d8d3a0e191dc8aef83df36773c07cb3d06",
"internalRef": "295738415",
"log": "ab2685d8d3a0e191dc8aef83df36773c07cb3d06\nfix: Dataproc v1 - AutoscalingPolicy annotation\n\nThis adds the second resource name pattern to the\nAutoscalingPolicy resource.\n\nCommitter: @lukesneeringer\nPiperOrigin-RevId: 295738415\n\n8a1020bf6828f6e3c84c3014f2c51cb62b739140\nUpdate cloud asset api v1p4beta1.\n\nPiperOrigin-RevId: 295286165\n\n5cfa105206e77670369e4b2225597386aba32985\nAdd service control related proto build rule.\n\nPiperOrigin-RevId: 295262088\n\nee4dddf805072004ab19ac94df2ce669046eec26\nmonitoring v3: Add prefix \"https://cloud.google.com/\" into the link for global access\ncl 295167522, get ride of synth.py hacks\n\nPiperOrigin-RevId: 295238095\n\nd9835e922ea79eed8497db270d2f9f85099a519c\nUpdate some minor docs changes about user event proto\n\nPiperOrigin-RevId: 295185610\n\n5f311e416e69c170243de722023b22f3df89ec1c\nfix: use correct PHP package name in gapic configuration\n\nPiperOrigin-RevId: 295161330\n\n6cdd74dcdb071694da6a6b5a206e3a320b62dd11\npubsub: v1 add client config annotations and retry config\n\nPiperOrigin-RevId: 295158776\n\n5169f46d9f792e2934d9fa25c36d0515b4fd0024\nAdded cloud asset api v1p4beta1.\n\nPiperOrigin-RevId: 295026522\n\n56b55aa8818cd0a532a7d779f6ef337ba809ccbd\nFix: Resource annotations for CreateTimeSeriesRequest and ListTimeSeriesRequest should refer to valid resources. TimeSeries is not a named resource.\n\nPiperOrigin-RevId: 294931650\n\n0646bc775203077226c2c34d3e4d50cc4ec53660\nRemove unnecessary languages from bigquery-related artman configuration files.\n\nPiperOrigin-RevId: 294809380\n\n8b78aa04382e3d4147112ad6d344666771bb1909\nUpdate backend.proto for schemes and protocol\n\nPiperOrigin-RevId: 294788800\n\n80b8f8b3de2359831295e24e5238641a38d8488f\nAdds artman config files for bigquerystorage endpoints v1beta2, v1alpha2, v1\n\nPiperOrigin-RevId: 294763931\n\n2c17ac33b226194041155bb5340c3f34733f1b3a\nAdd parameter to sample generated for UpdateInstance. Related to https://github.com/googleapis/python-redis/issues/4\n\nPiperOrigin-RevId: 294734008\n\nd5e8a8953f2acdfe96fb15e85eb2f33739623957\nMove bigquery datatransfer to gapic v2.\n\nPiperOrigin-RevId: 294703703\n\nefd36705972cfcd7d00ab4c6dfa1135bafacd4ae\nfix: Add two annotations that we missed.\n\nPiperOrigin-RevId: 294664231\n\n8a36b928873ff9c05b43859b9d4ea14cd205df57\nFix: Define the \"bigquery.googleapis.com/Table\" resource in the BigQuery Storage API (v1beta2).\n\nPiperOrigin-RevId: 294459768\n\nc7a3caa2c40c49f034a3c11079dd90eb24987047\nFix: Define the \"bigquery.googleapis.com/Table\" resource in the BigQuery Storage API (v1).\n\nPiperOrigin-RevId: 294456889\n\n5006247aa157e59118833658084345ee59af7c09\nFix: Make deprecated fields optional\nFix: Deprecate SetLoggingServiceRequest.zone in line with the comments\nFeature: Add resource name method signatures where appropriate\n\nPiperOrigin-RevId: 294383128\n\neabba40dac05c5cbe0fca3a35761b17e372036c4\nFix: C# and PHP package/namespace capitalization for BigQuery Storage v1.\n\nPiperOrigin-RevId: 294382444\n\nf8d9a858a7a55eba8009a23aa3f5cc5fe5e88dde\nfix: artman configuration file for bigtable-admin\n\nPiperOrigin-RevId: 294322616\n\n0f29555d1cfcf96add5c0b16b089235afbe9b1a9\nAPI definition for (not-yet-launched) GCS gRPC.\n\nPiperOrigin-RevId: 294321472\n\nfcc86bee0e84dc11e9abbff8d7c3529c0626f390\nfix: Bigtable Admin v2\n\nChange LRO metadata from PartialUpdateInstanceMetadata\nto UpdateInstanceMetadata. (Otherwise, it will not build.)\n\nPiperOrigin-RevId: 294264582\n\n6d9361eae2ebb3f42d8c7ce5baf4bab966fee7c0\nrefactor: Add annotations to Bigtable Admin v2.\n\nPiperOrigin-RevId: 294243406\n\nad7616f3fc8e123451c8b3a7987bc91cea9e6913\nFix: Resource type in CreateLogMetricRequest should use logging.googleapis.com.\nFix: ListLogEntries should have a method signature for convenience of calling it.\n\nPiperOrigin-RevId: 294222165\n\n63796fcbb08712676069e20a3e455c9f7aa21026\nFix: Remove extraneous resource definition for cloudkms.googleapis.com/CryptoKey.\n\nPiperOrigin-RevId: 294176658\n\n"
}
},
{
"git": {
"name": "synthtool",
"remote": "rpc://devrel/cloud/libraries/tools/autosynth",
"sha": "dd7cd93888cbeb1d4c56a1ca814491c7813160e8"
}
},
{
Expand Down

0 comments on commit c1e3253

Please sign in to comment.