Skip to content

Commit

Permalink
fix(compute): remove proto3_optional from parent_id (#712) (#712)
Browse files Browse the repository at this point in the history
- [ ] Regenerate this pull request now.

Source-Link: googleapis/googleapis@fd16b6a

Source-Link: googleapis/googleapis-gen@d935b98
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDkzNWI5ODQ3YTFiNzA4YWI0ZTY5NjMyMGJhNjBjZTAzNDFjNWQ3YSJ9

fix(compute): replace missing REQUIRED for parent_id (#711)
Source-Link: googleapis/googleapis@4bb6fd6

Source-Link: googleapis/googleapis-gen@c7d0653
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzdkMDY1MzNiZTZlMjQ3MGUzNmI5ZjM1MWFlNGZmNDc5YTQ3ZGM1MyJ9
  • Loading branch information
gcf-owl-bot[bot] authored Apr 14, 2022
1 parent 3e1acc6 commit b34b29c
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 34 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9946,7 +9946,10 @@ message InsertFirewallPolicyRequest {
FirewallPolicy firewall_policy_resource = 495049532 [(google.api.field_behavior) = REQUIRED];

// Parent ID for this request. The ID can be either be "folders/[FOLDER_ID]" if the parent is a folder or "organizations/[ORGANIZATION_ID]" if the parent is an organization.
optional string parent_id = 459714768 [(google.cloud.operation_request_field) = "parent_id"];
string parent_id = 459714768 [
(google.cloud.operation_request_field) = "parent_id",
(google.api.field_behavior) = REQUIRED
];

// An optional request ID to identify requests. Specify a unique request ID so that if you must retry your request, the server will know to ignore the request if it has already been completed. For example, consider a situation where you make an initial request and the request times out. If you make the request again with the same request ID, the server can check if original operation with the same request ID was received, and if so, will ignore the second request. This prevents clients from accidentally creating duplicate commitments. The request ID must be a valid UUID with the exception that zero UUID is not supported ( 00000000-0000-0000-0000-000000000000).
optional string request_id = 37109963;
Expand Down
5 changes: 1 addition & 4 deletions packages/google-cloud-compute/protos/protos.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 7 additions & 21 deletions packages/google-cloud-compute/protos/protos.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 1 addition & 6 deletions packages/google-cloud-compute/protos/protos.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

'use strict';

function main(firewallPolicyResource) {
function main(firewallPolicyResource, parentId) {
// [START compute_v1_generated_FirewallPolicies_Insert_async]
/**
* TODO(developer): Uncomment these variables before running the sample.
Expand Down Expand Up @@ -48,6 +48,7 @@ function main(firewallPolicyResource) {
// Construct request
const request = {
firewallPolicyResource,
parentId,
};

// Run request
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3514,7 +3514,7 @@
"segments": [
{
"start": 25,
"end": 58,
"end": 59,
"type": "FULL"
}
],
Expand Down

0 comments on commit b34b29c

Please sign in to comment.