Skip to content

Commit

Permalink
feat!: drop node8, remove eslint, update gax, fix generated protos, r…
Browse files Browse the repository at this point in the history
…un the generator (#423)
  • Loading branch information
alexander-fenster authored Apr 11, 2020
1 parent 618e7d7 commit aa77d2b
Show file tree
Hide file tree
Showing 33 changed files with 2,896 additions and 1,765 deletions.
3 changes: 3 additions & 0 deletions packages/google-cloud-videointelligence/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": "./node_modules/gts"
}
15 changes: 0 additions & 15 deletions packages/google-cloud-videointelligence/.eslintrc.yml

This file was deleted.

2 changes: 1 addition & 1 deletion packages/google-cloud-videointelligence/.jsdoc.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module.exports = {
includePattern: '\\.js$'
},
templates: {
copyright: 'Copyright 2019 Google, LLC.',
copyright: 'Copyright 2020 Google LLC',
includeDate: false,
sourceFiles: false,
systemName: '@google-cloud/video-intelligence',
Expand Down
8 changes: 0 additions & 8 deletions packages/google-cloud-videointelligence/.prettierrc

This file was deleted.

17 changes: 17 additions & 0 deletions packages/google-cloud-videointelligence/.prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// Copyright 2020 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

module.exports = {
...require('gts/.prettierrc.json')
}
18 changes: 8 additions & 10 deletions packages/google-cloud-videointelligence/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"author": "Google Inc",
"engines": {
"node": ">=8.10.0"
"node": ">=10"
},
"repository": "googleapis/nodejs-video-intelligence",
"main": "build/src/index.js",
Expand All @@ -29,31 +29,28 @@
],
"scripts": {
"docs": "jsdoc -c .jsdoc.js",
"lint": "gts fix && eslint --fix samples/*.js",
"lint": "gts fix",
"samples-test": "cd samples/ && npm link ../ && npm install && npm test && cd ../",
"system-test": "c8 mocha build/system-test --timeout 600000",
"test": "c8 mocha build/test",
"fix": "eslint --fix '**/*.js'",
"fix": "gts fix",
"docs-test": "linkinator docs",
"predocs-test": "npm run docs",
"prelint": "cd samples; npm link ../; npm i",
"prelint": "cd samples; npm link ../; npm install",
"clean": "gts clean",
"compile": "tsc -p . && cp -r protos build/",
"compile-protos": "compileProtos src",
"prepare": "npm run compile"
},
"dependencies": {
"google-gax": "^1.14.2"
"google-gax": "^2.1.0"
},
"devDependencies": {
"@types/mocha": "^7.0.0",
"@types/node": "^12.12.29",
"@types/sinon": "^9.0.0",
"c8": "^7.0.0",
"eslint": "^6.0.0",
"eslint-config-prettier": "^6.0.0",
"eslint-plugin-node": "^11.0.0",
"eslint-plugin-prettier": "^3.1.0",
"gts": "^1.1.2",
"gts": "^2.0.0",
"jsdoc": "^3.6.3",
"jsdoc-fresh": "^1.0.2",
"jsdoc-region-tag": "^1.0.4",
Expand All @@ -62,6 +59,7 @@
"null-loader": "^3.0.0",
"pack-n-play": "^1.0.0-2",
"prettier": "^1.17.1",
"sinon": "^9.0.2",
"ts-loader": "^6.2.1",
"typescript": "^3.8.3",
"webpack": "^4.42.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-videointelligence/protos/protos.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
var $Reader = $protobuf.Reader, $Writer = $protobuf.Writer, $util = $protobuf.util;

// Exported root namespace
var $root = $protobuf.roots["default"] || ($protobuf.roots["default"] = {});
var $root = $protobuf.roots._google_cloud_video_intelligence_2_10_0_protos || ($protobuf.roots._google_cloud_video_intelligence_2_10_0_protos = {});

$root.google = (function() {

Expand Down
16 changes: 12 additions & 4 deletions packages/google-cloud-videointelligence/protos/protos.json
Original file line number Diff line number Diff line change
Expand Up @@ -4332,34 +4332,41 @@
"extend": "google.protobuf.MethodOptions"
},
"Operations": {
"options": {
"(google.api.default_host)": "longrunning.googleapis.com"
},
"methods": {
"ListOperations": {
"requestType": "ListOperationsRequest",
"responseType": "ListOperationsResponse",
"options": {
"(google.api.http).get": "/v1/{name=operations}"
"(google.api.http).get": "/v1/{name=operations}",
"(google.api.method_signature)": "name,filter"
}
},
"GetOperation": {
"requestType": "GetOperationRequest",
"responseType": "Operation",
"options": {
"(google.api.http).get": "/v1/{name=operations/**}"
"(google.api.http).get": "/v1/{name=operations/**}",
"(google.api.method_signature)": "name"
}
},
"DeleteOperation": {
"requestType": "DeleteOperationRequest",
"responseType": "google.protobuf.Empty",
"options": {
"(google.api.http).delete": "/v1/{name=operations/**}"
"(google.api.http).delete": "/v1/{name=operations/**}",
"(google.api.method_signature)": "name"
}
},
"CancelOperation": {
"requestType": "CancelOperationRequest",
"responseType": "google.protobuf.Empty",
"options": {
"(google.api.http).post": "/v1/{name=operations/**}:cancel",
"(google.api.http).body": "*"
"(google.api.http).body": "*",
"(google.api.method_signature)": "name"
}
},
"WaitOperation": {
Expand Down Expand Up @@ -4485,6 +4492,7 @@
},
"rpc": {
"options": {
"cc_enable_arenas": true,
"go_package": "google.golang.org/genproto/googleapis/rpc/status;status",
"java_multiple_files": true,
"java_outer_classname": "StatusProto",
Expand Down
Loading

0 comments on commit aa77d2b

Please sign in to comment.