Skip to content

Commit

Permalink
fix: drop support for node.js 4.x and 9.x (#57)
Browse files Browse the repository at this point in the history
* fix: drop support for node.js 4.x and 9.x

* moar fixing
  • Loading branch information
JustinBeckwith authored and alexander-fenster committed Jul 10, 2018
1 parent 4530e01 commit 963b33c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 36 deletions.
41 changes: 6 additions & 35 deletions packages/google-cloud-videointelligence/.circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ workflows:
version: 2
tests:
jobs: &workflow_jobs
- node4:
filters:
tags:
only: /.*/
- node6:
filters:
tags:
Expand All @@ -15,30 +11,22 @@ workflows:
filters:
tags:
only: /.*/
- node9:
filters:
tags:
only: /.*/
- node10:
filters:
tags:
only: /.*/
- lint:
requires:
- node4
- node6
- node8
- node9
- node10
filters:
tags:
only: /.*/
- docs:
requires:
- node4
- node6
- node8
- node9
- node10
filters:
tags:
Expand Down Expand Up @@ -69,9 +57,9 @@ workflows:
only: master
jobs: *workflow_jobs
jobs:
node4:
node6:
docker:
- image: 'node:4'
- image: 'node:6'
steps: &unit_tests_steps
- checkout
- run: &remove_package_lock
Expand All @@ -88,25 +76,12 @@ jobs:
- run: &npm_install_and_link
name: Install and link the module.
command: npm install
- run:
name: Run unit tests.
command: npm test
- run:
name: Submit coverage data to codecov.
command: node_modules/.bin/codecov
when: always
node6:
docker:
- image: 'node:6'
steps: *unit_tests_steps
- run: npm test
- run: node_modules/.bin/codecov
node8:
docker:
- image: 'node:8'
steps: *unit_tests_steps
node9:
docker:
- image: 'node:9'
steps: *unit_tests_steps
node10:
docker:
- image: 'node:10'
Expand Down Expand Up @@ -167,9 +142,5 @@ jobs:
- image: 'node:8'
steps:
- checkout
- run:
name: Set NPM authentication.
command: 'echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc'
- run:
name: Publish the module to npm.
command: npm publish
- run: 'echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc'
- run: npm publish
2 changes: 1 addition & 1 deletion packages/google-cloud-videointelligence/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"author": "Google Inc",
"engines": {
"node": ">=4.0.0"
"node": ">=6.0.0"
},
"repository": "googleapis/nodejs-video-intelligence",
"main": "src/index.js",
Expand Down

0 comments on commit 963b33c

Please sign in to comment.