rename to float()

googleapis · Mar 14, 2017 · 927b5c9 · 927b5c9
1 parent a7eca2a
commit 927b5c9
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 14 deletions.
diff --git a/packages/spanner/src/codec.js b/packages/spanner/src/codec.js
@@ -35,15 +35,15 @@ function SpannerDate(value) {
 
 codec.SpannerDate = SpannerDate;
 
-function Double(value) {
+function Float(value) {
   this.value = value;
 }
 
-Double.prototype.valueOf = function() {
+Float.prototype.valueOf = function() {
   return this.value;
 };
 
-codec.Double = Double;
+codec.Float = Float;
 
 function Int(value) {
   this.value = value.toString();
@@ -78,7 +78,7 @@ function decode(value, field) {
         break;
       }
       case 'FLOAT64': {
-        decoded = new codec.Double(decoded);
+        decoded = new codec.Float(decoded);
         break;
       }
       case 'INT64': {
@@ -146,7 +146,7 @@ codec.decode = decode;
 function encode(value) {
   function preEncode(value) {
     var numberShouldBeStringified =
-      !(value instanceof Double) &&
+      !(value instanceof Float) &&
       is.int(value) ||
       value instanceof Int ||
       is.infinite(value) ||
@@ -155,7 +155,7 @@ function encode(value) {
     if (is.date(value)) {
       value = value.toJSON();
     } else if (value instanceof SpannerDate ||
-               value instanceof Double ||
+               value instanceof Float ||
                value instanceof Int) {
       value = value.value;
     } else if (Buffer.isBuffer(value)) {

diff --git a/packages/spanner/src/index.js b/packages/spanner/src/index.js
@@ -111,14 +111,14 @@ Spanner.prototype.date = Spanner.date = function(value) {
 /**
  * Helper function to get a Cloud Spanner Float64 object.
  *
- * @param {string|number} value - The int as a number or string.
+ * @param {string|number} value - The float as a number or string.
  * @return {object}
  *
  * @example
- * var date = spanner.int(10);
+ * var date = spanner.float(10);
  */
-Spanner.prototype.double = Spanner.double = function(value) {
-  return new codec.Double(value);
+Spanner.prototype.float = Spanner.float = function(value) {
+  return new codec.Float(value);
 };
 
 /**
@@ -493,7 +493,8 @@ Spanner.prototype.operation = function(name) {
  */
 common.util.promisifyAll(Spanner, {
   exclude: [
-    'double',
+    'date',
+    'float',
     'getInstanceConfigs',
     'instance',
     'int',

diff --git a/packages/spanner/system-test/spanner.js b/packages/spanner/system-test/spanner.js
@@ -638,6 +638,7 @@ describe('Spanner', function() {
 
       var EXPECTED_ROW = extend(true, {}, INSERT_ROW);
       EXPECTED_ROW.DOB = DATE;
+      EXPECTED_ROW.Float = Spanner.float(FLOAT);
       EXPECTED_ROW.Int = Spanner.int(INT);
       EXPECTED_ROW.PhoneNumbers = [
         Spanner.int(PHONE_NUMBERS[0]),

diff --git a/packages/spanner/test/codec.js b/packages/spanner/test/codec.js
@@ -138,7 +138,7 @@ describe('codec', function() {
         }
       });
 
-      assert(decoded instanceof codec.Double);
+      assert(decoded instanceof codec.Float);
       assert.strictEqual(decoded.value, value);
     });
 
@@ -370,7 +370,7 @@ describe('codec', function() {
     });
 
     it('should encode FLOAT64', function() {
-      var value = new codec.Double(10);
+      var value = new codec.Float(10);
 
       var encoded = codec.encode(value);
 

diff --git a/packages/spanner/test/index.js b/packages/spanner/test/index.js
@@ -37,7 +37,8 @@ var fakeUtil = extend({}, util, {
 
     promisified = true;
     assert.deepEqual(options.exclude, [
-      'double',
+      'date',
+      'float',
       'getInstanceConfigs',
       'instance',
       'int',