chore: udpate lint configs (#158)

googleapis · Nov 9, 2018 · 652d20e · 652d20e
1 parent b1e684a
commit 652d20e
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 8 deletions.
diff --git a/packages/google-cloud-language/package.json b/packages/google-cloud-language/package.json
@@ -33,12 +33,12 @@
     "cover": "nyc --reporter=lcov mocha test/*.js && nyc report",
     "docs": "jsdoc -c .jsdoc.js",
     "generate-scaffolding": "repo-tools generate all && repo-tools generate lib_samples_readme -l samples/ --config ../.cloud-repo-tools.json",
-    "lint": "eslint src/ samples/ system-test/ test/",
-    "prettier": "prettier --write src/*.js src/*/*.js samples/*.js samples/*/*.js test/*.js test/*/*.js system-test/*.js system-test/*/*.js",
+    "lint": "eslint '**/*.js'",
     "samples-test": "cd samples/ && npm test && cd ../",
     "system-test": "mocha system-test/*.js --timeout 600000",
     "test-no-cover": "mocha test/*.js",
-    "test": "npm run cover"
+    "test": "npm run cover",
+    "fix": "eslint --fix '**/*.js'"
   },
   "dependencies": {
     "google-gax": "^0.20.0",

diff --git a/packages/google-cloud-language/samples/package.json b/packages/google-cloud-language/samples/package.json
@@ -7,6 +7,10 @@
   },
   "repository": "googleapis/nodejs-language",
   "private": true,
+  "files": [
+    "*.js",
+    "resources"
+  ],
   "scripts": {
     "test": "mocha"
   },

diff --git a/packages/google-cloud-language/smoke-test/.eslintrc.yml b/packages/google-cloud-language/smoke-test/.eslintrc.yml
@@ -0,0 +1,5 @@
+---
+env:
+  mocha: true
+rules:
+  no-console: off
diff --git a/packages/google-cloud-language/smoke-test/language_service_smoke_test.js b/packages/google-cloud-language/smoke-test/language_service_smoke_test.js
@@ -28,7 +28,8 @@ describe('LanguageServiceSmokeTest', () => {
       content: content,
       type: type,
     };
-    client.analyzeSentiment({document: document})
+    client
+      .analyzeSentiment({document: document})
       .then(responses => {
         const response = responses[0];
         console.log(response);

diff --git a/packages/google-cloud-language/synth.py b/packages/google-cloud-language/synth.py
@@ -16,10 +16,11 @@
         library,
         excludes=['package.json', 'README.md', 'src/index.js'])
 
+# Update common templates
 common_templates = gcp.CommonTemplates()
 templates = common_templates.node_library()
 s.copy(templates)
 
 # Node.js specific cleanup
 subprocess.run(['npm', 'install'])
-subprocess.run(['npm', 'run', 'prettier'])
+subprocess.run(['npm', 'run', 'fix'])
diff --git a/packages/google-cloud-language/system-test/.eslintrc.yml b/packages/google-cloud-language/system-test/.eslintrc.yml
@@ -2,5 +2,4 @@
 env:
   mocha: true
 rules:
-  node/no-unpublished-require: off
   no-console: off
diff --git a/packages/google-cloud-language/test/.eslintrc.yml b/packages/google-cloud-language/test/.eslintrc.yml
@@ -1,5 +1,3 @@
 ---
 env:
   mocha: true
-rules:
-  node/no-unpublished-require: off