Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Display Java Diff between Monorepo and Split Repos #8448

Closed
wants to merge 1 commit into from
Closed

chore: Display Java Diff between Monorepo and Split Repos #8448

wants to merge 1 commit into from

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Sep 23, 2022 •
edited
Loading

WIP

@snippet-bot
Copy link

snippet-bot bot commented Sep 23, 2022 •
edited
Loading

Here is the summary of possible violations 😱

There are 14 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.

Here is the summary of changes.

You are about to add 14 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@lqiu96 lqiu96 force-pushed the main-diff_java branch 2 times, most recently from 3399111 to 16e7474 Compare September 23, 2022 19:18
@lqiu96 lqiu96 mentioned this pull request Sep 23, 2022
Merged
suztomo
suztomo reviewed Sep 26, 2022
View reviewed changes
...ute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/BaseTest.java Outdated
Comment on lines 28 to 27
return COMPUTE_PREFIX + "-" + placeholder + "-" + UUID.randomUUID().toString().substring(0, 8);
return "gapic-" + placeholder + UUID.randomUUID().toString().substring(0, 8);
Copy link
Member

@suztomo suztomo Sep 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual commit to monorepo 8e4378d OK to have diff.

suztomo
suztomo reviewed Sep 26, 2022
View reviewed changes
...iner/google-cloud-container/src/test/java/com/google/cloud/container/v1/it/ITSystemTest.java Outdated
@@ -26,7 +26,6 @@
import com.google.container.v1.ListOperationsResponse;
import com.google.container.v1.NodePool;
import com.google.container.v1.Operation;
import com.google.container.v1.Operation.Status;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual commit to monorepo. OK to have diff 8e4378d

@github-actions github-actions bot force-pushed the main-diff_java branch 6 times, most recently from f43fa85 to 14cbe56 Compare September 26, 2022 20:28
@suztomo
Copy link
Member

suztomo commented Sep 26, 2022

You want to have the pull request on the diff script and Java code diff separated.

@github-actions github-actions bot force-pushed the main-diff_java branch 4 times, most recently from 82d9684 to 67717ec Compare September 27, 2022 15:06
@lqiu96 lqiu96 mentioned this pull request Sep 27, 2022
Closed
@lqiu96
Copy link
Contributor Author

lqiu96 commented Sep 27, 2022 •
edited
Loading

RESOLVED: Data-Catalog Diff

Split Repos: Changes came from googleapis/java-datacatalog#795
Monorepo: Changes were reverted in #8340

Create a PR to revert changes that have been reverted: #8467
MERGED: googleapis/java-datacatalog#857

RESOLVED: Dataproc Diff

Need this PR to be merged in split repos
MERGED: googleapis/java-dataproc#922
MERGED: Need this PR to be merged in monorepo: #8462
Tomo has resolved the issue with the PR.

Web Security Scanner Diff

Should be resolved in: #8471

Java Vision Diff

Should be resolved in: #8472

Java-BigQuery-Data-Exhange

This is an odd difference...

Monorepo PR:

Split Repo PR

Diff in files:

  • Category.java (deleted)
  • CommonProto.java (deleted)
  • pom.xml (modified by Blake)

@github-actions github-actions bot force-pushed the main-diff_java branch 2 times, most recently from d6f82d2 to 6468782 Compare September 27, 2022 19:47
This was referenced Sep 27, 2022
Closed
Closed
@github-actions github-actions bot force-pushed the main-diff_java branch 2 times, most recently from 22ced07 to ad8245f Compare September 28, 2022 14:50
@github-actions github-actions bot force-pushed the main-diff_java branch 14 times, most recently from af9dfa1 to 4b294ab Compare October 17, 2022 13:19
@github-actions github-actions bot force-pushed the main-diff_java branch 11 times, most recently from d9e9388 to a487ed4 Compare October 18, 2022 18:40
@suztomo suztomo mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqiu96 @suztomo