Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added local implementation of the service and tests. #656

Merged
merged 3 commits into from
Mar 9, 2016

Commits on Feb 19, 2016

  1. Configuration menu
    Copy the full SHA
    a1ec7f4 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2016

  1. Added RPC layer of tests for local helpers. Closes googleapis#665.

    Debugged parsing for options. Fixed context for the server URLs
    and regular expression parsing. Fixed paging. Improved error
    detection for missing zones vs. non-existent changes.
    mderka committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    04f354a View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2016

  1. The following has been done within multiple iterations:

    Refactored URL parsing and removed unnecessary doc in local helper.
    Refactored to use AtomicReference instead of singleton Map.
    Adjusted tests of paging to test that pages contain expected objects.
    Added check and test for deleting non-empy zone.
    Removed RrsetWapper and used tailMap in listing.
    Added @VisibleForTesting annotations.
    Added fails to expected exceptions. Added error message checks.
    Addressed codacy suggestions.
    Assigned project ID to the helper and test.
    Added pool of executors instead of spawning one threads.
    Reduced number of threads.
    mderka committed Mar 9, 2016
    Configuration menu
    Copy the full SHA
    1f06caf View commit details
    Browse the repository at this point in the history