Avoids exposing zone id #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes id a read-only string instead of BigInteger. Includes rewriting testsfor Zone.
googlebot
added
the
cla: yes
| } | ||
|
|
||
| /** | ||
| * Deletes the zone. The method first attempts to delete the zone by ID. If the zone is not found | ||
| * or id is not set, it attempts to delete by name. | ||
| * Deletes the zone. The method first deletes the zone by name which must always be initialized. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| * the zone by ID and if not found then by name. Returns a {@link ChangeRequest} with | ||
| * server-assigned ID or {@code null} if the zone was not found. | ||
| * Submits {@link ChangeRequest} to the service for it to applied to this zone. The method | ||
| * searches for zone by name which must always be initialized. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good. @mderka feel free to merge after fixing the javadoc. |
|
Fixed. Merging. |
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
Source-Link: googleapis/synthtool@18d4e9b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45
github-actions bot
pushed a commit
that referenced
this pull request
Nov 16, 2022
) * chore(java): add a note in README for migrated split repos Disable renovate bot and flaky bot for split repositories that have moved to the Java monorepo. The Java monorepo will pass the "monorepo=True" parameter to java.common_templates method in its owlbot.py files so that the migration note will not appear in the README in the monorepo. Co-authored-by: Jeff Ching <chingor@google.com> Source-Link: googleapis/synthtool@d4b2916 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Jeff Ching <chingor@google.com>
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all the methods that identify zones by id. Also switches zone id attribute from BigInteger to String. Makes id read only attribute settable by package scope builder method only, and forces name to be set.
Adds options for zone create method.
Addressed all comments of #610. Fixes #610.