Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for null in Project.load() #520

Merged
merged 2 commits into from
Jan 4, 2016
Merged

Check for null in Project.load() #520

merged 2 commits into from
Jan 4, 2016

Conversation

ajkannan
Copy link

@ajkannan ajkannan commented Jan 4, 2016

From discussion in #516

@ajkannan ajkannan added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: cloudresourcemanager Issues related to the Resource Manager API. labels Jan 4, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 4, 2016
mziccard
mziccard reviewed Jan 4, 2016
View reviewed changes
gcloud-java-resourcemanager/src/main/java/com/google/gcloud/resourcemanager/Project.java
@@ -42,12 +42,13 @@ public Project(ResourceManager resourceManager, ProjectInfo projectInfo) {
/**
* Constructs a Project object that contains project information loaded from the server.
*
* @return Project object containing the project's metadata
* @return Project object containing the project's metadata or
* null if the project doesn't exist

This comment was marked as spam.

Sign in to view

@ajkannan
Copy link
Author

ajkannan commented Jan 4, 2016

@mziccard fixed in place

@mziccard
Copy link
Contributor

mziccard commented Jan 4, 2016

@ajkannan What do you think about adding tests for Project's load and reload for the cases when the service returns null? Something like:

@Test
public void testLoadNull() {
  expect(resourceManager.get(PROJECT_INFO.projectId())).andReturn(null);
  replay(resourceManager);
  assertNull(Project.load(resourceManager, PROJECT_INFO.projectId()));
}

@ajkannan
Copy link
Author

ajkannan commented Jan 4, 2016

I added a test for reload already, and I think that covers load since reload uses load. But I can still add a test like the one you listed in case reload doesn't use load in the future.

@ajkannan
Copy link
Author

ajkannan commented Jan 4, 2016

@mziccard Added the testLoadNull test

@mziccard
Copy link
Contributor

mziccard commented Jan 4, 2016

Looks good to me!

ajkannan added a commit that referenced this pull request Jan 4, 2016
@ajkannan
Merge pull request #520 from ajkannan/check-null-load
0fa9b51 
Check for null in Project.load()
@ajkannan ajkannan merged commit 0fa9b51 into googleapis:master Jan 4, 2016
@ajkannan ajkannan deleted the check-null-load branch January 4, 2016 21:05
github-actions bot pushed a commit that referenced this pull request Jun 21, 2022
@renovate-bot
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
8c48082 
…onfig to v1.5.0 (#520)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.4.0` -> `1.5.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/compatibility-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/confidence-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-config</summary>

### [`v1.5.0`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#&#8203;150-httpsgithubcomgoogleapisjava-shared-configcomparev140v150-2022-06-10)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.4.0...v1.5.0)

##### Features

-   add build scripts for native image testing in Java 17 ([#&#8203;1440](https://togithub.com/googleapis/java-shared-config/issues/1440)) ([#&#8203;475](https://togithub.com/googleapis/java-shared-config/issues/475)) ([e4dfc1b](https://togithub.com/googleapis/java-shared-config/commit/e4dfc1ba29295158c78c8fcf94467d2a6a33538a))
-   to produce Java 8 compatible bytecode when using JDK 9+ ([2468276](https://togithub.com/googleapis/java-shared-config/commit/2468276145cdfe1ca911b52f765e026e77661a09))

##### Dependencies

-   update surefire.version to v3.0.0-m7 ([bbfe663](https://togithub.com/googleapis/java-shared-config/commit/bbfe66393af3e49612c9c1e4334ba39c133ea1d0))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-securitycenter-settings).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@gcf-owl-bot
chore: new owl bot post processor docker image (googleapis#520)
aec72aa 
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:3796fe5c26bbf814f0a82a2eab2749b5710f87e7197dc011e5fa3c694e532462
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@renovate-bot @gcf-owl-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v26 (#…
6973dea 
…520)

* chore(deps): update dependency com.google.cloud:libraries-bom to v26

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
@release-please
chore(main): release 0.14.3 (#520)
6190187 
🤖 I have created a release *beep* *boop*
---


## [0.14.3](googleapis/java-dialogflow-cx@v0.14.2...v0.14.3) (2022-07-26)


### Documentation

* **samples:** add try blocks to clean up resources in samples and sample tests ([#521](googleapis/java-dialogflow-cx#521)) ([6526525](googleapis/java-dialogflow-cx@6526525))
* **samples:** add webhook samples ([#479](googleapis/java-dialogflow-cx#479)) ([86a3ee5](googleapis/java-dialogflow-cx@86a3ee5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
3f9af6a 
…1575) (#520)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@release-please
chore(main): release 1.6.12-SNAPSHOT (#520)
1e78fa4 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: cloudresourcemanager Issues related to the Resource Manager API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajkannan @mziccard @googlebot