Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Compute to beta version #4691

Closed
wants to merge 2 commits into from

Conversation

andreamlin
Copy link
Contributor

@andreamlin andreamlin commented Mar 18, 2019

Following pattern from #4581

@andreamlin andreamlin requested a review from a team as a code owner March 18, 2019 17:45
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2019
@andreamlin andreamlin requested a review from kolea2 March 18, 2019 17:45
@andreamlin
Copy link
Contributor Author

@kolea2 PTAL

@@ -12,7 +12,7 @@
<parent>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-clients</artifactId>
<version>0.83.1-alpha-SNAPSHOT</version><!-- {x-version-update:google-cloud-clients:current} -->
<version>0.83.1-beta-SNAPSHOT</version><!-- {x-version-update:google-cloud-clients:current} -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this line, since google-cloud-clients is still at alpha.

@sduskis
Copy link
Contributor

sduskis commented Mar 19, 2019

@andreamlin, there are some additional changes required before this will build.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 25, 2019
@sduskis sduskis added the needs work This is a pull request that needs a little love. label Mar 25, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Mar 25, 2019
@sduskis
Copy link
Contributor

sduskis commented May 26, 2019

@andreamlin, this PR is quite stale at this point. Would it be ok to close this?

@andreamlin
Copy link
Contributor Author

andreamlin commented May 28, 2019 via email

@sduskis sduskis closed this May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. needs work This is a pull request that needs a little love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants