Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package private dead code from the subscriber client library. #4589

Merged

Conversation

dpcollins-google
Copy link

None of this code is ever called, and none of it is usable outside of the library.

…None of this code is ever called, and none of it is usable outside of the library.
@dpcollins-google dpcollins-google requested a review from a team as a code owner February 28, 2019 15:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 28, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 28, 2019
@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #4589 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4589      +/-   ##
============================================
- Coverage     49.18%   49.17%   -0.01%     
+ Complexity    21962    21952      -10     
============================================
  Files          2078     2078              
  Lines        207507   207457      -50     
  Branches      24121    24107      -14     
============================================
- Hits         102055   102017      -38     
+ Misses        97276    97267       -9     
+ Partials       8176     8173       -3
Impacted Files Coverage Δ Complexity Δ
...cloud/pubsub/v1/StreamingSubscriberConnection.java 63.2% <ø> (-7.69%) 9 <0> (-9)
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 83.13% <100%> (+3.89%) 17 <0> (ø) ⬇️
...gle/cloud/pubsub/v1/SubscriptionAdminSettings.java 14.28% <0%> (-1.59%) 4% <0%> (-1%)
...gle/cloud/storage/testing/RemoteStorageHelper.java 57.72% <0%> (+2.43%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 921be7b...532bcd5. Read the comment docs.

@sduskis sduskis merged commit 1e18a7d into googleapis:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants