Add InsertAllRequest, InsertAllResponse and model classes for table data #443

mziccard · 2015-12-09T13:47:50Z

This PR will probably require some discussion :) I am eager to receive any feedback.
It adds:

InsertAllRequest and InsertAllResponse to insert data using TableData: insertAll.
TableRow and FieldValue to hold the results of TableData: list and query

Remarks:

We discussed with @aozarov about adding more information to FieldValue.Kind as REPEATED_OF_PRIMITIVE and REPEATED_OF_RECORD but I realized that an empty repeated field is returned as an empty array and there's no way to say whether it is of primitive or record type.

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/FieldValue.java

+
+/**
+ * Google BigQuery Table Field Value class. Objects of this class represent values of a BigQuery
+ * Table Field. A list of values forms a {@link TableRow}. Tables rows can be get as the result of


…le data

mziccard · 2015-12-10T15:28:39Z

Thanks @ajkannan for the pass. I fixed the comments in place.

mziccard · 2015-12-10T16:43:50Z

Should we make all value getters in FieldValue throw the same exception? Right now they either throw ClassCastException, IllegalStateException, NumberFormatException or NullPointerException depending on the type of conversion being asked. What do you think?

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/FieldValue.java

+  /**
+   * The field value's kind, giving information on the field's content type.
+   */
+  public enum Kind {


gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/FieldValue.java

+   * {@link Field.Type#floatingPoint()}, {@link Field.Type#integer()},
+   * {@link Field.Type#timestamp()}).
+   *
+   * @throws ClassCastException if the field has not primitive type


gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/InsertAllRequest.java

+  /**
+   * A Google Big Query row to be inserted into a table. Each {@code RowToInsert} has an associated
+   * id used by BigQuery to detect duplicate insertion requests on a best-effort basis.
+   *


- Add static FROM_PB_FUNCTION in FieldValue - Rename Kind to Attribute in FieldValue - Add isNull() and document NPEs in FieldValue getters - Change has type to is a type in FieldValue - Copy row content in RowToInsert constructor - Add factory method for null id to RowToInsert - Use isEmpty() instead of size() > 0 in InsertAllResponse - Better unit testing

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/InsertAllRequest.java

+    /**
+     * Creates a row to be inserted without associated id.
+     *
+     * @param id id of the row, used to identify duplicates


aozarov · 2015-12-11T17:20:37Z

Looks great! Few nits.

mziccard · 2015-12-11T18:54:09Z

Fixed all comments in 43eb31b. I added checkNotNull to stringValue, repeatedValue and recordValue and documented the NPE. I also documented that value() can return null. 43eb31b also fixes some other javadoc errors.

Add InsertAllRequest, InsertAllResponse and model classes for table data

- [ ] Regenerate this pull request now. BREAKING CHANGE: proto file name is changed from assuredworkloads_v1beta1.proto to assuredworkloads.proto PiperOrigin-RevId: 454705538 Source-Link: googleapis/googleapis@cf681da Source-Link: googleapis/googleapis-gen@9880990 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTg4MDk5MDA5ZjgwOTRiOWMyZjNlZmQ3NzNhMTI2OTZjOTNjOGUzOCJ9 chore: Integrate new gapic-generator-java and rules_gapic PiperOrigin-RevId: 454027580 Source-Link: googleapis/googleapis@1b22277 Source-Link: googleapis/googleapis-gen@e04cea2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9

…apis#443) This PR updates the docker container used for OwlBot. This container performs post-processing tasks when pull-requests are opened on your repository, such as: * copying generated files into place. * generating common files from templates. Version sha256:b3c6a25dc0b7474ef211b01aac777f24efa3cb97ef04d22f886b2b78f55744d8 was published at 2021-04-14T16:24:29.580Z.

🤖 I have created a release *beep* *boop* --- ### [2.1.10](googleapis/java-workflows@v2.1.9...v2.1.10) (2022-04-15) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.10.0 ([#442](googleapis/java-workflows#442)) ([3955b44](googleapis/java-workflows@3955b44)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.0.0](googleapis/java-assured-workloads@v1.1.0...v2.0.0) (2022-07-01) ### ⚠ BREAKING CHANGES * proto file name is changed from assuredworkloads_v1beta1.proto to assuredworkloads.proto ### Features * Enable REST transport for most of Java and Go clients ([googleapis#448](googleapis/java-assured-workloads#448)) ([2ec7bb4](googleapis/java-assured-workloads@2ec7bb4)) * ITAR June Preview Launch ([googleapis#453](googleapis/java-assured-workloads#453)) ([eeed2fd](googleapis/java-assured-workloads@eeed2fd)) * Removed _v1beta1 suffix from proto file names ([googleapis#443](googleapis/java-assured-workloads#443)) ([853eb5b](googleapis/java-assured-workloads@853eb5b)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#450](googleapis/java-assured-workloads#450)) ([c115d5f](googleapis/java-assured-workloads@c115d5f)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#447](googleapis/java-assured-workloads#447)) ([3b07e54](googleapis/java-assured-workloads@3b07e54)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@7336562 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d4b80feffe1579818cdc39466152e9de95789a193408506cd4a1ffbe8804dc00

🤖 I have created a release *beep* *boop* --- ## [2.4.3](googleapis/java-functions@v2.4.2...v2.4.3) (2022-07-13) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-functions/issues/1485)) ([#443](googleapis/java-functions#443)) ([7687177](googleapis/java-functions@7687177)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [0.13.0](googleapis/java-analytics-admin@v0.12.1...v0.13.0) (2022-08-09) ### Features * add `GetAttributionSettings`, `UpdateAttributionSettings` methods to the Admin API v1alpha ([6fb226f](googleapis/java-analytics-admin@6fb226f)) * add `GetAudience`, 'ListAudience', 'CreateAudience', 'UpdateAudience', 'ArchiveAudience' methods to the Admin API v1alpha ([#441](googleapis/java-analytics-admin#441)) ([6fb226f](googleapis/java-analytics-admin@6fb226f)) * add `RunAccessReport` method to the Admin API v1alpha ([#442](googleapis/java-analytics-admin#442)) ([f999d82](googleapis/java-analytics-admin@f999d82)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#438](googleapis/java-analytics-admin#438)) ([b48af30](googleapis/java-analytics-admin@b48af30)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [googleapis-common-protos](https://togithub.com/googleapis/python-api-common-protos) | `==1.56.3` -> `==1.56.4` | [![age](https://badges.renovateapi.com/packages/pypi/googleapis-common-protos/1.56.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/googleapis-common-protos/1.56.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/googleapis-common-protos/1.56.4/compatibility-slim/1.56.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/googleapis-common-protos/1.56.4/confidence-slim/1.56.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).

mziccard added the api: bigquery Issues related to the BigQuery API. label Dec 9, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2015

ajkannan reviewed Dec 10, 2015
View reviewed changes

Add InsertAllRequest and InsertAllResponse. Add model classes for tab…

27f4d0d

…le data

mziccard force-pushed the bigquery branch from 20dfb48 to 27f4d0d Compare December 10, 2015 15:24

aozarov reviewed Dec 10, 2015
View reviewed changes

Document ClassCastException in FieldValue

1674c9c

aozarov reviewed Dec 10, 2015
View reviewed changes

aozarov reviewed Dec 11, 2015
View reviewed changes

mziccard added 2 commits December 11, 2015 13:16

Remove TableRow class

50d381f

aozarov reviewed Dec 11, 2015
View reviewed changes

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/InsertAllRequest.java

/**

* Creates a row to be inserted without associated id.

*

* @param id id of the row, used to identify duplicates

This comment was marked as spam.

Sign in to view

Fix javadoc error, add checkNotNull to FieldValue getters

aacc383

mziccard force-pushed the bigquery branch from 43eb31b to aacc383 Compare December 11, 2015 22:16

aozarov added a commit that referenced this pull request Dec 11, 2015

Merge pull request #443 from mziccard/bigquery

7dfca8e

Add InsertAllRequest, InsertAllResponse and model classes for table data

aozarov merged commit 7dfca8e into googleapis:bigquery Dec 11, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add InsertAllRequest, InsertAllResponse and model classes for table data #443

Add InsertAllRequest, InsertAllResponse and model classes for table data #443

mziccard commented Dec 9, 2015

This comment was marked as spam.

mziccard commented Dec 10, 2015

mziccard commented Dec 10, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Dec 11, 2015

mziccard commented Dec 11, 2015

Add InsertAllRequest, InsertAllResponse and model classes for table data #443

Add InsertAllRequest, InsertAllResponse and model classes for table data #443

Conversation

mziccard commented Dec 9, 2015

This comment was marked as spam.

mziccard commented Dec 10, 2015

mziccard commented Dec 10, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Dec 11, 2015

mziccard commented Dec 11, 2015