Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: generation instructions, version ordering #3451

Merged
merged 2 commits into from
Jul 11, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion utilities/generate_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,15 @@ def run_generate_api(config_path, artifact_type, noisy=False):
print('**** REMAINING MANUAL WORK: *****')
print('This script doesn\'t set up new clients. If this is a new client, you need to:')
print('1. Add the new proto and grpc modules into google-api-grpc/pom.xml')
print('2. Add version declarations for the proto and grpc modules in google-api-grpc/pom.xml')
print('3. Copy an existing client pom.xml to the new client directory, update its text')
print('4. Copy an existing client README.md to the new client directory, update its text')
print('5. Add the new proto, grpc, and client modules into versions.txt')
print('6. Add the new proto, grpc, and client modules into google-cloud-bom/pom.xml')
print('7. Run `utilities/replace_versions.py` to update the module versions')
print('7. Add the API to the list in the root README.md')
print('8. Add the client module into the list in google-cloud-clients/pom.xml')
print('9. Add the stub package for the client into the stubs list in google-cloud-clients/pom.xml')
print('10. Run `utilities/replace_versions.py` to update the module versions')

def main():
parser = argparse.ArgumentParser(description='Regenerate a single API.')
Expand Down
10 changes: 5 additions & 5 deletions versions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,14 @@ grpc-google-cloud-dialogflow-v2beta1:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-dlp-v2:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-error-reporting-v1beta1:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-firestore-v1beta1:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-iot-v1:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-language-v1:1.17.0:1.17.1-SNAPSHOT
grpc-google-cloud-language-v1beta2:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-logging-v2:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-monitoring-v3:1.17.0:1.17.1-SNAPSHOT
grpc-google-cloud-os-login-v1:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-pubsub-v1:1.17.0:1.17.1-SNAPSHOT
grpc-google-cloud-redis-v1beta1:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-spanner-admin-database-v1:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-spanner-admin-instance-v1:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-spanner-v1:0.18.0:0.18.1-SNAPSHOT
Expand All @@ -42,8 +44,6 @@ grpc-google-cloud-video-intelligence-v1p1beta1:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-vision-v1:1.17.0:1.17.1-SNAPSHOT
grpc-google-cloud-vision-v1p1beta1:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-vision-v1p2beta1:1.17.0:1.17.1-SNAPSHOT
grpc-google-cloud-iot-v1:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-redis-v1beta1:0.18.0:0.18.1-SNAPSHOT
grpc-google-cloud-websecurityscanner-v1alpha:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-bigquerydatatransfer-v1:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-bigtable-admin-v2:0.18.0:0.18.1-SNAPSHOT
Expand All @@ -56,12 +56,14 @@ proto-google-cloud-dialogflow-v2beta1:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-dlp-v2:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-error-reporting-v1beta1:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-firestore-v1beta1:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-iot-v1:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-language-v1:1.17.0:1.17.1-SNAPSHOT
proto-google-cloud-language-v1beta2:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-logging-v2:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-monitoring-v3:1.17.0:1.17.1-SNAPSHOT
proto-google-cloud-os-login-v1:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-pubsub-v1:1.17.0:1.17.1-SNAPSHOT
proto-google-cloud-redis-v1beta1:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-spanner-admin-database-v1:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-spanner-admin-instance-v1:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-spanner-v1:0.18.0:0.18.1-SNAPSHOT
Expand All @@ -80,8 +82,6 @@ proto-google-cloud-video-intelligence-v1p1beta1:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-vision-v1:1.17.0:1.17.1-SNAPSHOT
proto-google-cloud-vision-v1p1beta1:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-vision-v1p2beta1:1.17.0:1.17.1-SNAPSHOT
proto-google-cloud-iot-v1:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-redis-v1beta1:0.18.0:0.18.1-SNAPSHOT
proto-google-cloud-websecurityscanner-v1alpha:0.18.0:0.18.1-SNAPSHOT

#
Expand Down Expand Up @@ -114,6 +114,7 @@ google-cloud-dns:0.53.0-alpha:0.53.1-alpha-SNAPSHOT
google-cloud-errorreporting:0.53.0-beta:0.53.1-beta-SNAPSHOT
google-cloud-examples:0.53.0-alpha:0.53.1-alpha-SNAPSHOT
google-cloud-firestore:0.53.0-beta:0.53.1-beta-SNAPSHOT
google-cloud-iot:0.53.0-beta:0.53.1-beta-SNAPSHOT
google-cloud-language:1.35.0:1.35.1-SNAPSHOT
google-cloud-logging:1.35.0:1.35.1-SNAPSHOT
google-cloud-logging-logback:0.53.0-alpha:0.53.1-alpha-SNAPSHOT
Expand All @@ -137,5 +138,4 @@ google-cloud-translate:1.35.0:1.35.1-SNAPSHOT
google-cloud-util:0.53.0-alpha:0.53.1-alpha-SNAPSHOT
google-cloud-video-intelligence:0.53.0-beta:0.53.1-beta-SNAPSHOT
google-cloud-vision:1.35.0:1.35.1-SNAPSHOT
google-cloud-iot:0.53.0-beta:0.53.1-beta-SNAPSHOT
google-cloud-websecurityscanner:0.53.0-alpha:0.53.1-alpha-SNAPSHOT