Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: reverse the padding direction #2478

Closed
wants to merge 2 commits into from
Closed

pubsub: reverse the padding direction #2478

wants to merge 2 commits into from

Commits on Oct 4, 2017

  1. pubsub: reverse the padding direction 

    Previously, padding works by sending deadline extension before
messages expire.
Eg, if message expires in 10 seconds, we try to send extension
in 9 seconds.
A problem is with high latency, highly congested, or highly buffered
connections.
If we want the server to expire messages in 10 seconds,
there is no way to set 10 seconds for more of padding.

This commit reverse the padding direction.
Eg, if we want the message to expire in 10 seconds, we send the
extension at 10 seconds, but we ask the server for 11 seconds.
In this way, if we want the padding to be 10 seconds, we just
ask the server for 20 seconds.

This logic only works for streaming pull though,
as streaming pull allows deadline to be changed individually
for each stream.
Consequently, the tests are changed to reflect the new logic
and the relevant tests are disabled for polling pull.

This commit also increases the default padding to 5 seconds,
since high latency has been observed in production.

Fixes #2465.
    @pongad
    pongad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    8a0752b View commit details
    Browse the repository at this point in the history

  2. delete prints

    @pongad
    pongad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    46a001c View commit details
    Browse the repository at this point in the history