Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make pubsub high perf compile #1474

Merged
merged 8 commits into from
Dec 13, 2016
Merged

make pubsub high perf compile #1474

merged 8 commits into from
Dec 13, 2016

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Dec 12, 2016

This commit merges master into the branch and makes it the branch compile.

AckDeadlineRenewerTest is still timing out. I'll get to that in a later commit.

garrettjonesgoogle and others added 5 commits December 9, 2016 10:08
@garrettjonesgoogle
Update version to 0.8.1-SNAPSHOT (#1467)
bb99a20 
Also, update versions in README to 0.8.0
@tswast @garrettjonesgoogle
Add link to Maven Central for maven-central badge. (#1468)
b85e1cc 
Used to link to the image, which wasn't super useful.
@pongad
Merge remote-tracking branch 'upstream/master' into pubsub-hp
83b5caa
@pongad
fix more races in pubsub tests
9a308a2 
Previously BlockingProcessStreamReader has a terminate() method,
used to tell the Reader to stop reading from the emulator process.

This causes an inter-process race.
If the Reader stops before reading emulator's output,
the emulator process will hang as it tries to write to stdout/stderr
as there's no one to read from the other side of the pipe.

Since there is no way to safely stop the Reader,
this commit deletes the method and its associated test.

Additionally, the timeout for LocalSystemTest is increased to 3 minutes,
since the emulator, somehow, consistently takes just longer than a
minute to shut down.
@pongad
make pubsub high perf compile
fb6c5ae
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a409eac on pongad:pubsub-hp into ** on GoogleCloudPlatform:pubsub-hp**.

@garrettjonesgoogle
Copy link
Member

Looks like the tests are probably getting locked up somewhere.

@pongad
Copy link
Contributor Author

pongad commented Dec 12, 2016

@garrettjonesgoogle Yes, the test are locked up at the bug fixed by #1473.

@garrettjonesgoogle
Copy link
Member

If the tests pass, then LGTM

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 43937d7 on pongad:pubsub-hp into ** on GoogleCloudPlatform:pubsub-hp**.

@pongad
Copy link
Contributor Author

pongad commented Dec 13, 2016

@garrettjonesgoogle AppVeyor seems to be timing out for some reason. I don't have a retry button though...

@pongad
Copy link
Contributor Author

pongad commented Dec 13, 2016

A rerun is passing at https://ci.appveyor.com/project/pongad/google-cloud-java-dujhn/build/1 .
I'll go ahead and merge this.

@pongad pongad merged commit 4dd7d79 into googleapis:pubsub-hp Dec 13, 2016
@pongad pongad deleted the pubsub-hp branch December 13, 2016 03:34
@pongad pongad restored the pubsub-hp branch December 13, 2016 03:34
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#93)
1fa3735 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#206)
0ba7c4e 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#795)
559081b 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#203)
e947235 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#247)
2267219 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#677)
4c620f3 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#175)
6d86747 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#192)
28a9bed 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#52)
5885728 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#528)
e8b6b4d 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#947)
f729626 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#114)
3fb7270 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#271)
924a59b 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#213)
6682c63 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#701)
2e6121e 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#848)
113d9de 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#236)
f157049 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#266)
3b9f222 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#280)
e93b1e3 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#777)
9518bd8 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#478)
4f3b32c 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#27)
668942c 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#696)
c791dbe 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#615)
f6f1a7b 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#191)
2a38f56 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#898)
889ddce 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#32)
88b542f 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#55)
668ac45 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#709)
2721041 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#187)
7247c7a 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#44)
f94ed94 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#798)
ab23af6 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#469)
186e9cb 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#242)
d652e80 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#816)
cf6b8d1 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#802)
4613bee 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#878)
f3c0961 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#727)
92a51f2 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#370)
cf47f09 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#857)
a5a3eaa 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@garrettjonesgoogle garrettjonesgoogle

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pongad @coveralls @garrettjonesgoogle @googlebot @tswast