Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update storage use example in README to create BlobInfo with builder … #1139

Closed
wants to merge 1 commit into from
Closed

update storage use example in README to create BlobInfo with builder … #1139

wants to merge 1 commit into from

Conversation

…instead of passing a String blobname, which is not supported
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 5, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 85.871% when pulling 0c1a633 on drmarshall:storage-doc-example into 64115e4 on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor

mziccard commented Aug 8, 2016

Hi @drmarshall, thanks for doing this!

The example in the README is taken from the CreateAndListBucketsAndBlobs snippet. I believe that to fix the README we should just replace:

Blob blob = storage.create(
    "my_blob_name", "a simple blob".getBytes(UTF_8), "text/plain");

with

Blob blob = bucket.create(
    "my_blob_name", "a simple blob".getBytes(UTF_8), "text/plain");

Also, could you make the CLA bot happy? :)

@mziccard
Copy link
Contributor

Closing this as it was fixed in #1202. Thanks again @drmarshall for reporting this.

@mziccard mziccard closed this Aug 26, 2016
@drmarshall
Copy link
Author

Thanks Marco. Will stick to issues until I can appease CLA bot.

On Fri, Aug 26, 2016 at 12:03 PM Marco Ziccardi notifications@github.com
wrote:

Closing this as it was fixed in #1202
#1202. Thanks
again @drmarshall https://github.com/drmarshall for reporting this.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1139 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFvcOCzU9gUjG7Qksf9tZcFrLcgyAIH4ks5qjxxAgaJpZM4JeGsv
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants