add null check to JobInfo.fromPb(Job) and .toPb() (#3770)

Fixes #3739.
googleapis · Oct 5, 2018 · d197058 · d197058
1 parent 211bfad
commit d197058
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/...-cloud-clients/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/JobInfo.java b/...-cloud-clients/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/JobInfo.java
@@ -180,7 +180,9 @@ static final class BuilderImpl extends Builder {
         this.statistics = JobStatistics.fromPb(jobPb);
       }
       this.userEmail = jobPb.getUserEmail();
-      this.configuration = JobConfiguration.fromPb(jobPb.getConfiguration());
+      if (jobPb.getConfiguration() != null) {
+        this.configuration = JobConfiguration.fromPb(jobPb.getConfiguration());
+      }
     }
 
     @Override
@@ -375,7 +377,9 @@ Job toPb() {
     if (statistics != null) {
       jobPb.setStatistics(statistics.toPb());
     }
-    jobPb.setConfiguration(configuration.toPb());
+    if(configuration != null){
+      jobPb.setConfiguration(configuration.toPb());
+    }
     return jobPb;
   }
 

diff --git a/...-cloud-clients/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/JobTest.java b/...-cloud-clients/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/JobTest.java
@@ -523,6 +523,16 @@ public void testToAndFromPb() {
     compareJob(expectedJob, Job.fromPb(serviceMockReturnsOptions, expectedJob.toPb()));
   }
 
+  @Test
+  public void testToAndFromPbWithoutConfiguration() {
+    JobInfo jobInfo =
+        JobInfo.newBuilder(null)
+            .build();
+    initializeExpectedJob(4, jobInfo);
+    replay(bigquery);
+    compareJob(expectedJob, Job.fromPb(serviceMockReturnsOptions, expectedJob.toPb()));
+  }
+
   private void compareJob(Job expected, Job value) {
     assertEquals(expected, value);
     compareJobInfo(expected, value);