Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): retry errors from last recv on uploads #9616

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

BrennaEpp
Copy link
Contributor

Missed this case when switching to bidi streams

@BrennaEpp BrennaEpp requested review from a team as code owners March 20, 2024 17:58
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Mar 20, 2024
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Do you feel like our existing test coverage is sufficient for this? If some of these error/continue cases are not hit by our conformance tests, we should talk about adding those.

@@ -1872,6 +1872,7 @@ func (w *gRPCWriter) uploadBuffer(recvd int, start int64, doneReading bool) (*st

// Send a request with as many bytes as possible.
// Loop until all bytes are sent.
sendBytes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool but I've literally never seen this in Go code before. Can you add a clarifying comment? It's just pretty rare syntax.

@BrennaEpp
Copy link
Contributor Author

Overall looks good. Do you feel like our existing test coverage is sufficient for this? If some of these error/continue cases are not hit by our conformance tests, we should talk about adding those.

This is caught by our conformance tests, but they are currently skipped. Once the support in the testbench for retrying bidi writes is merged we can remove the skip and it would catch this.

@cojenco
Copy link
Contributor

cojenco commented Mar 20, 2024

Overall looks good. Do you feel like our existing test coverage is sufficient for this? If some of these error/continue cases are not hit by our conformance tests, we should talk about adding those.

This is caught by our conformance tests, but they are currently skipped. Once the support in the testbench for retrying bidi writes is merged we can remove the skip and it would catch this.

Update: retry support for bidi writes just merged and is in the v0.43.0 testbench release

@BrennaEpp BrennaEpp merged commit b6574aa into googleapis:main Mar 21, 2024
9 checks passed
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants