Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace grpc/metadata's NewContext and FromContext calls with appropriate Incoming/Outgoing versions #627

Closed
wants to merge 1 commit into from
Closed

Replace grpc/metadata's NewContext and FromContext calls with appropriate Incoming/Outgoing versions #627

wants to merge 1 commit into from

Conversation

dfawley
Copy link
Contributor

@dfawley dfawley commented May 12, 2017

Fixes #624

@dfawley
Copy link
Contributor Author

dfawley commented May 18, 2017

Is there some way to re-run the tests for this change? The failure happened during go install without any error message, so I'm hoping it will pass if it's retried.

@rakyll
Copy link
Contributor

rakyll commented May 18, 2017

We use Gerrit for code reviews and kokoro for CI, do you want me to resubmit this commit via Gerrit?

@rakyll
Copy link
Contributor

rakyll commented May 18, 2017

You can also follow the instructions at https://github.com/GoogleCloudPlatform/google-cloud-go/blob/master/CONTRIBUTING.md to create a CL.

@dfawley dfawley mentioned this pull request May 18, 2017
Closed
@dfawley
Copy link
Contributor Author

dfawley commented May 18, 2017

I moved this over to Gerrit. Thanks for the pointer.

@dfawley dfawley closed this May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @rakyll