Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): wait for XML read req to finish to avoid data races #11527

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

BrennaEpp
Copy link
Contributor

Fixes TestRetryReadStallEmulated failing with -race

Fixes TestRetryReadStallEmulated failing with `-race`
@BrennaEpp BrennaEpp requested review from a team as code owners January 29, 2025 21:00
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 29, 2025
@BrennaEpp BrennaEpp requested a review from tritone January 29, 2025 21:00
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on this one; thanks @BrennaEpp

@BrennaEpp BrennaEpp enabled auto-merge (squash) January 29, 2025 23:31
@BrennaEpp BrennaEpp merged commit 782e12a into googleapis:main Jan 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants