Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(spanner): temporarily skip TestRequestIDHeader if using multiplexedSessions #11309

Conversation

odeke-em
Copy link
Contributor

Temporarily skip RequestIDHeader tests if environment variable

GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS=true

is set. This ensures that normal development can go on without breaking CI/CD for other developers of this repository.

Updates #11308

@odeke-em odeke-em requested review from a team as code owners December 18, 2024 13:39
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Dec 18, 2024
@odeke-em odeke-em changed the title test(spanner): temporarily skip TestRequestIDHeader if set test(spanner): temporarily skip TestRequestIDHeader if using multiplexedSessions Dec 18, 2024
@odeke-em odeke-em force-pushed the spanner-skip-request-id-header-tests-if-multiplexed-sessions branch from 2fe046a to 74ecf66 Compare December 18, 2024 13:41
rahul2393
rahul2393 previously approved these changes Dec 18, 2024
Copy link
Contributor

@rahul2393 rahul2393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have isMultiplexEnabled gloabl env

@rahul2393 rahul2393 self-requested a review December 18, 2024 13:43
@rahul2393 rahul2393 dismissed their stale review December 18, 2024 13:44

need some changes

…xedSessions

Temporarily skip RequestIDHeader tests if environment variable

    GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS=true

is set. This ensures that normal development can go on without
breaking CI/CD for other developers of this repository.

Updates googleapis#11308
@odeke-em odeke-em force-pushed the spanner-skip-request-id-header-tests-if-multiplexed-sessions branch from 74ecf66 to baf51d3 Compare December 18, 2024 13:50
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2024
@rahul2393 rahul2393 merged commit 4c5e4f0 into googleapis:main Dec 18, 2024
7 checks passed
@odeke-em odeke-em deleted the spanner-skip-request-id-header-tests-if-multiplexed-sessions branch December 18, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants