refactor(bigquery): cleanup unused params #11149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR revisits a few of the internal method signatures and simplifies them in the cases where a param is effectively unused or returns only a single possible value. Fixes here are scoped only to the main bigquery package, a subsequent PR will do the same for managedwriter.
product-auto-label
bot
added
the
api: bigquery
alvarowolfx
approved these changes
Nov 19, 2024
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
shollyman
added a commit
to shollyman/google-cloud-go
that referenced
this pull request
Nov 19, 2024
Another unparam related PR, this one focused on reducing unused params in the managedwriter and its adapt subpackage. Followup to googleapis#11149
shollyman
added a commit
that referenced
this pull request
Nov 21, 2024
Another unparam related PR, this one focused on reducing unused params in the managedwriter and its adapt subpackage. Followup to #11149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revisits a few of the internal method signatures and simplifies them in the cases where a param is effectively unused or returns only a single possible value. Fixes here are scoped only to the main bigquery package, a subsequent PR will introduce similar refactors for managedwriter