Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: support logger configuration #6957

Closed
stevenh opened this issue Oct 28, 2022 · 0 comments · Fixed by #6958
Closed

spanner: support logger configuration #6957

stevenh opened this issue Oct 28, 2022 · 0 comments · Fixed by #6958
Assignees
@rahul2393
Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@stevenh
Copy link
Contributor

stevenh commented Oct 28, 2022

Is your feature request related to a problem? Please describe.
When using spannertest its logging via spanner client includes a lot of harmless errors.

Describe the solution you'd like
Allow the logger for spanner client to be configurable.

Describe alternatives you've considered
Setting the global logger to discard but that's not ideal.

Additional context
PR incoming
@stevenh stevenh added the triage me I really want to be triaged. label Oct 28, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Oct 28, 2022
stevenh added a commit to stevenh/google-cloud-go that referenced this issue Oct 28, 2022
@stevenh
feat(spanner): configurable logger
41cbaa9 
Expose logger in ClientConfig so consumers can set a logger.

This is useful when using spannertest which logs a lot of harmless
errors.

Fixes: googleapis#6957
@stevenh stevenh mentioned this issue Oct 28, 2022
Merged
@rahul2393 rahul2393 added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Oct 31, 2022
rahul2393 added a commit that referenced this issue Nov 3, 2022
@stevenh @rahul2393
feat(spanner): configurable logger (#6958)
bd85442 
Expose logger in ClientConfig so consumers can set a logger.

This is useful when using spannertest which logs a lot of harmless
errors.

Fixes: #6957

Co-authored-by: rahul2393 <irahul@google.com>
@release-please release-please bot mentioned this issue Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul2393 rahul2393

Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(spanner): configurable logger stevenh/google-cloud-go
2 participants
@stevenh @rahul2393