Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigtable): add create table metadata support #6813

Merged

Conversation

kimihrr
Copy link
Contributor

@kimihrr kimihrr commented Oct 6, 2022

  • Add DeletionProtection field to TableConf and TableInfo
  • Change CreateTable and CreatePresplitTable functions to pass DeletionProtection equals to None to CreateTableFromConf which can accept DeletionProtection equals to None, Protected or Unprotected
  • Add unit tests for CreateTableFromConf
  • Add integration tests for DeletionProtection

kimihrr and others added 30 commits September 26, 2022 15:17
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#911

Changes:

feat(aiplatform): add model_source_info to Model in aiplatform v1beta1 model.proto
  PiperOrigin-RevId: 476411826
  Source-Link: googleapis/googleapis@72f0faa

docs(language): fix docstring formatting
  Committer: @parthea
  PiperOrigin-RevId: 476410563
  Source-Link: googleapis/googleapis@7f579ee

feat(aiplatform): add model_source_info to Model in aiplatform v1 model.proto
  PiperOrigin-RevId: 476193748
  Source-Link: googleapis/googleapis@a7f3890

chore(retail): revert removal of LRO mixin
  PiperOrigin-RevId: 476177134
  Source-Link: googleapis/googleapis@174b42d

fix(dialogflow/cx): revert removal of LRO mixin
  PiperOrigin-RevId: 476177109
  Source-Link: googleapis/googleapis@652c4c1

feat(iam): remove ListApplicablePolicies
  PiperOrigin-RevId: 475955031
  Source-Link: googleapis/googleapis@65376f4

feat(bigquery/analyticshub): rename nodejs analyticshub library package name
  PiperOrigin-RevId: 475881872
  Source-Link: googleapis/googleapis@8933d4b

chore(dataplex): remove duplicated IAM mixin for Node.js library
  PiperOrigin-RevId: 475855448
  Source-Link: googleapis/googleapis@b7c271c

feat(dataproc): add support for Dataproc metric configuration
  Committer: @AkshatBhargava
  PiperOrigin-RevId: 475750057
  Source-Link: googleapis/googleapis@30517fd

chore(bigquery/storage): update gapic-generator-python-1.4.4 with unit tests generation fixes
  PiperOrigin-RevId: 475683078
  Source-Link: googleapis/googleapis@df791ce

feat(language): Add support for V1 and V2 classification models for the V1Beta2 API
  PiperOrigin-RevId: 475604619
  Source-Link: googleapis/googleapis@044a15c

feat(language): Add support for V1 and V2 classification models for the V1 API
  PiperOrigin-RevId: 475599241
  Source-Link: googleapis/googleapis@05b99f9

feat(aiplatform): add timestamp_outside_retention_rows_count to ImportFeatureValuesResponse and ImportFeatureValuesOperationMetadata in aiplatform v1 featurestore_service.proto feat: add RemoveContextChildren rpc to aiplatform v1 metadata_service.proto feat: add order_by to ListArtifactsRequest, ListContextsRequest, and ListExecutionsRequest in aiplatform v1 metadata_service.proto
  PiperOrigin-RevId: 475580702
  Source-Link: googleapis/googleapis@af65a19

feat(aiplatform): add timestamp_outside_retention_rows_count to ImportFeatureValuesResponse and ImportFeatureValuesOperationMetadata in aiplatform v1beta1 featurestore_service.proto feat: add RemoveContextChildren rpc to aiplatform v1beta1 metadata_service.proto feat: add order_by to ListArtifactsRequest, ListContextsRequest, and ListExecutionsRequest in aiplatform v1beta1 metadata_service.proto feat: add InputArtifact to RuntimeConfig in aiplatform v1beta1 pipeline_job.proto feat: add read_mask to ListPipelineJobsRequest in aiplatform v1beta1 pipeline_service.proto feat: add TransferLearningConfig in aiplatform v1beta1 study.proto
  PiperOrigin-RevId: 475580307
  Source-Link: googleapis/googleapis@dbc83bd

chore(dataform): update gapic-generator-python to 1.4.3 with test fixes
  PiperOrigin-RevId: 475399737
  Source-Link: googleapis/googleapis@4c4a9a2

feat(asset): Add client library support for AssetService v1 SavedQuery APIs Committer: jeffreyai@
  PiperOrigin-RevId: 475366952
  Source-Link: googleapis/googleapis@7428dad
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#912
…pis#6695)

This PR adds support for automatic retry of failed appends.  Failures are evaluated both from the perspective of any receive errors getting the response, as well as any response that may be embedded in response from the service.  Previous behavior was to simply re-attempt failures when issuing the append.

This PR also adds a new WriterOption (`DisableWriteRetries(disable bool)`) to control this behavior (default is to have retries enabled).

For users sensitive to write duplication, this PR also exposes a new TotalAttempts method on the AppendResult, which will indicate the total number of times this write was attempted.

This also tries to clean up retries in general a bit more.  The generated client will already retry unary RPCs, subject to the [service config](https://github.com/googleapis/googleapis/blob/master/google/cloud/bigquery/storage/v1/bigquerystorage_grpc_service_config.json) present when generating the storage API.

We specifically clarify/introduce two additional kinds of retries above that: a unary retry and a stateless retry.

The unary retry is used to (re)open the underlying bidi network connection which appends are sent upon, as we want to be resilient to reconnection.  The unary retry is effectively stateful for the operation of reopening the connection, and thus uses a gax-based backoff that backs off with increasing intervals.

The stateless retry is used when processing the responses returning from the backend on the bidi stream, where backing off incrementally doesn't make sense.  Instead, we use a base backoff and jitter, and for cases where a more severe backoff is warranted (throughput exhaustion) we use a multiplication factor.  The intent here is to provide backpressure which will eventually saturate the append queue and cause blocking/rejection of writes until the backlog recovers.
Adds retry config to grpcReader and grpcWriter types so that they can be propagated to operations as needed. Ensure that the configured values are used for all retry calls, and that UserProject is consistently passed through as well.
Add dual transport tests for HMAC keys and for PostPolicyV4.

One PostPolicyV4 test creates a second client with custom key behavior. I split this test into two separate tests, one of which fails for gRPC. I left this as a skip for now since it will require some digging in the constructor creds logic to fix.

I also cleaned up some layers of indirection around the various testConfig client methods, and now the multiTransportTest function can take client options to pass down to the client constructors which should make it easier to clean up some other tests which have custom client constructor logic.
…ogleapis#6761)

Per guidance from backend team, include FailedPrecondition as part
of the allowed retry.
I missed a case where the shouldRetry function could be nil
in googleapis#6754, which causes a panic in integration tests.

Fixes googleapis#6760 (this is the actual failure)
Fixes googleapis#6757
Fixes googleapis#6758
Fixes googleapis#6759
yoshi-automation and others added 8 commits October 25, 2022 14:58
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.


Corresponding genproto PR: https://togithub.com/googleapis/go-genproto/pull/923

Changes:

feat(spanner): Update transaction.proto to include different lock modes
  PiperOrigin-RevId: 481838475
  Source-Link: https://togithub.com/googleapis/googleapis/commit/922f1f33bb239addc9816fbbecbf15376e03a4aa

feat(kms): enable generation of Locations mixin
  PiperOrigin-RevId: 481650929
  Source-Link: https://togithub.com/googleapis/googleapis/commit/62e82e76c6ab8405731c1dfc9edb604745beedfb

feat(channel): Add CloudChannelReportsService to CloudChannel API
  PiperOrigin-RevId: 481642499
  Source-Link: https://togithub.com/googleapis/googleapis/commit/0c78b0c2ef2a623784a6434316c80ee33a33dac1

feat(securitycenter): Adding project/folder level parents to notification configs in SCC
  PiperOrigin-RevId: 481230115
  Source-Link: https://togithub.com/googleapis/googleapis/commit/94efa50017258958b7ce637bab25d459c67de8e9
🤖 I have created a release *beep* *boop*
---


## [1.43.0](https://togithub.com/googleapis/google-cloud-go/compare/bigquery/v1.42.0...bigquery/v1.43.0) (2022-10-24)


### Features

* **bigquery/analyticshub:** rename nodejs analyticshub library package name ([52dddd1](https://togithub.com/googleapis/google-cloud-go/commit/52dddd1ed89fbe77e1859311c3b993a77a82bfc7))
* **bigquery/storage/managedwriter:** Enable field name indirection ([googleapis#6247](https://togithub.com/googleapis/google-cloud-go/issues/6247)) ([1969273](https://togithub.com/googleapis/google-cloud-go/commit/19692735b0fbafa176d0315bda923528e1eedf6d))
* **bigquery/storage/managedwriter:** Retry on FailedPrecondition ([googleapis#6761](https://togithub.com/googleapis/google-cloud-go/issues/6761)) ([d1a444d](https://togithub.com/googleapis/google-cloud-go/commit/d1a444d769c9578b586bef608d343b4b0abd3658))
* **bigquery/storage/managedwriter:** Support append retries ([googleapis#6695](https://togithub.com/googleapis/google-cloud-go/issues/6695)) ([6ae9c67](https://togithub.com/googleapis/google-cloud-go/commit/6ae9c670a11d80b34872cb05fda933303b81851d))
* **bigquery/storage/managedwriter:** Switch to opt-in retry ([googleapis#6765](https://togithub.com/googleapis/google-cloud-go/issues/6765)) ([a3e97a6](https://togithub.com/googleapis/google-cloud-go/commit/a3e97a6f15ad1989ef815b9bd5838192f9f226f1))
* **bigquery:** Add remote function options to routine metadata ([googleapis#6702](https://togithub.com/googleapis/google-cloud-go/issues/6702)) ([d9a437d](https://togithub.com/googleapis/google-cloud-go/commit/d9a437de75a5f5151cd000d8f9a6b7fc567d8551))


### Bug Fixes

* **bigquery/storage/managedwriter:** Address possible resource leak ([googleapis#6775](https://togithub.com/googleapis/google-cloud-go/issues/6775)) ([979440b](https://togithub.com/googleapis/google-cloud-go/commit/979440b43573c1cfd744d3f63d0c633c7319ad46))
* **bigquery:** Avoid stack overflow on query param with recursive types ([googleapis#6890](https://togithub.com/googleapis/google-cloud-go/issues/6890)) ([854ccfc](https://togithub.com/googleapis/google-cloud-go/commit/854ccfca259d747759d283fc0d0053893f3c8f8d)), refs [googleapis#6884](https://togithub.com/googleapis/google-cloud-go/issues/6884)
* **bigquery:** Bq connection auth scopes ([googleapis#6752](https://togithub.com/googleapis/google-cloud-go/issues/6752)) ([8e09288](https://togithub.com/googleapis/google-cloud-go/commit/8e09288185f721d90288c3aa873980fc44b98613)), refs [googleapis#6744](https://togithub.com/googleapis/google-cloud-go/issues/6744)


### Documentation

* **bigquery/storage/managedwriter/adapt:** Typo in error string ([googleapis#6729](https://togithub.com/googleapis/google-cloud-go/issues/6729)) ([bb26153](https://togithub.com/googleapis/google-cloud-go/commit/bb26153d38475cd9784edbf241df84c368f5a166))
* **bigquery/storage/managedwriter:** Add retry info to package docs ([googleapis#6803](https://togithub.com/googleapis/google-cloud-go/issues/6803)) ([81e52e5](https://togithub.com/googleapis/google-cloud-go/commit/81e52e59dcf3c4a44108e039fb0e3a0e2ce8284f))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#927

Changes:

feat(dialogflow): Can directly set Cloud Speech model on the SpeechToTextConfig
  PiperOrigin-RevId: 482665674
  Source-Link: googleapis/googleapis@64926d5

docs(dialogflow/cx): Clarified TTL as time-to-live docs: Removed pre-GA disclaimer from Interaction Logging (has been GA for awhile)
  PiperOrigin-RevId: 482618841
  Source-Link: googleapis/googleapis@62443cf

feat(compute): Update Compute Engine API to revision 20221011 (googleapis#736)

  Source-Link: googleapis/googleapis@cb8c914

feat(pubsub): Provide easier access to IAM via the standard IAMPolicy client class
  PiperOrigin-RevId: 482013889
  Source-Link: googleapis/googleapis@5f68158

feat(kms): Provide easier access to IAM via the standard IAMPolicy client class
  PiperOrigin-RevId: 482013711
  Source-Link: googleapis/googleapis@6d38b26

Co-authored-by: Cody Oss <6331106+codyoss@users.noreply.github.com>
* chore(bigtable): update bttest for table deletion
* chore(ci): move vet to GitHub Action

* vet on main

* dedupe vet.sh

Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
This fixes GitHub issue googleapis#6519; see that issue for further commentary.

Co-authored-by: Eric Schmidt <erschmid@google.com>
Changes:

feat(accessapproval): start generating stubs dir

feat(accesscontextmanager): start generating stubs dir

feat(apigateway): start generating stubs dir

feat(apigeeconnect): start generating stubs dir

feat(appengine): start generating stubs dir

feat(artifactregistry): start generating stubs dir

feat(asset): start generating stubs dir

feat(assuredworkloads): start generating stubs dir

feat(automl): start generating stubs dir

feat(baremetalsolution): start generating stubs dir

feat(batch): start generating stubs dir

feat(beyondcorp): start generating stubs dir

feat(billing): start generating stubs dir

feat(binaryauthorization): start generating stubs dir

feat(certificatemanager): start generating stubs dir

feat(channel): start generating stubs dir

feat(cloudbuild): start generating stubs dir

feat(clouddms): start generating stubs dir

feat(cloudtasks): start generating stubs dir

feat(contactcenterinsights): start generating stubs dir

feat(container): start generating stubs dir

feat(datacatalog): start generating stubs dir

feat(datafusion): start generating stubs dir

feat(dataplex): start generating stubs dir

feat(dataproc): start generating stubs dir

feat(datastream): start generating stubs dir

feat(debugger): start generating stubs dir

feat(deploy): start generating stubs dir

feat(dialogflow): start generating stubs dir

feat(dlp): start generating stubs dir

feat(documentai): start generating stubs dir

feat(essentialcontacts): start generating stubs dir

feat(eventarc): start generating stubs dir

feat(filestore): start generating stubs dir

feat(functions): start generating stubs dir

feat(functions): start generating stubs dir

feat(gaming): start generating stubs dir

feat(gkebackup): start generating stubs dir

feat(gkemulticloud): start generating stubs dir

feat(gsuiteaddons): start generating stubs dir

feat(iam): start generating stubs dir

feat(iap): start generating stubs dir

feat(ids): start generating stubs dir

feat(iot): start generating stubs dir

feat(kms): start generating stubs dir

feat(language): start generating stubs dir

feat(longrunning): start generating stubs dir

feat(managedidentities): start generating stubs dir

feat(memcache): start generating stubs dir

feat(metastore): start generating stubs dir

feat(monitoring): start generating stubs dir

feat(networkconnectivity): start generating stubs dir

feat(networkmanagement): start generating stubs dir

feat(notebooks): start generating stubs dir

feat(optimization): start generating stubs dir

feat(orchestration): start generating stubs dir

feat(orgpolicy): start generating stubs dir

feat(osconfig): start generating stubs dir

feat(oslogin): start generating stubs dir

feat(policytroubleshooter): start generating stubs dir

feat(recaptchaenterprise/v2): start generating stubs dir

feat(recommender): start generating stubs dir

feat(redis): start generating stubs dir

feat(resourcemanager): start generating stubs dir

feat(resourcesettings): start generating stubs dir

feat(retail): start generating stubs dir

feat(run): start generating stubs dir

feat(scheduler): start generating stubs dir

feat(secretmanager): start generating stubs dir

feat(security): start generating stubs dir

feat(securitycenter): start generating stubs dir

feat(servicecontrol): start generating stubs dir

feat(servicedirectory): start generating stubs dir

feat(servicemanagement): start generating stubs dir

feat(serviceusage): start generating stubs dir

feat(shell): start generating stubs dir

feat(speech): start generating stubs dir

feat(storagetransfer): start generating stubs dir

feat(talent): start generating stubs dir

feat(texttospeech): start generating stubs dir

feat(tpu): start generating stubs dir

feat(trace): start generating stubs dir

feat(translate): start generating stubs dir

feat(video): start generating stubs dir

feat(videointelligence): start generating stubs dir

feat(vision/v2): start generating stubs dir

feat(vmmigration): start generating stubs dir

feat(vpcaccess): start generating stubs dir

feat(webrisk): start generating stubs dir

feat(websecurityscanner): start generating stubs dir

feat(workflows): start generating stubs dir
auto-merge was automatically disabled October 25, 2022 14:58

Head branch was pushed to by a user without write access

@kimihrr kimihrr requested a review from a team October 25, 2022 14:58
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Oct 25, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Oct 25, 2022
@telpirion telpirion enabled auto-merge (squash) October 25, 2022 19:06
@telpirion telpirion enabled auto-merge (squash) October 25, 2022 19:09
@telpirion telpirion added the automerge Merge the pull request once unit tests and other checks pass. label Oct 25, 2022
@telpirion telpirion merged commit d497377 into googleapis:main Oct 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.