Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: fix use of Bucket_RetentionPolicy.RetentionPeriod #6748

Closed
noahdietz opened this issue Sep 26, 2022 · 0 comments · Fixed by #6781
Closed

storage: fix use of Bucket_RetentionPolicy.RetentionPeriod #6748

noahdietz opened this issue Sep 26, 2022 · 0 comments · Fixed by #6781
Assignees
@noahdietz
Labels
api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.

Comments

@noahdietz
Copy link
Contributor

noahdietz commented Sep 26, 2022 •
edited
Loading

Bucket_RetentionPolicy.RetentionPeriod will get proto3_optional soon, changing it to a pointer. It is commented out right now, but should be fixed once regen lands the new change.

Only places that assign a value to Bucket_RetentionPolicy.RetentionPeriod need to be fixed. Places that use the GetRetentionPeriod accessor are unaffected (which is part of why we use the accessors to read values 😉).

As of right now, none of the integration tests enabled for gRPC use the RetentionPeriod field so we should see no disruptions there.
@noahdietz noahdietz added api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like. labels Sep 26, 2022
@noahdietz noahdietz self-assigned this Sep 26, 2022
@noahdietz noahdietz mentioned this issue Sep 26, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 27, 2022
@noahdietz
chore(storage): prep RetentionPeriod for proto3 optional (#6749)
9d2064d 
Precaution detailed in #6748.
telpirion pushed a commit that referenced this issue Sep 27, 2022
@noahdietz @telpirion
chore(storage): prep RetentionPeriod for proto3 optional (#6749)
9f8d1cf 
Precaution detailed in #6748.
kimihrr pushed a commit to kimihrr/google-cloud-go-kimia that referenced this issue Sep 28, 2022
@noahdietz @kimihrr
chore(storage): prep RetentionPeriod for proto3 optional (googleapis#…
2b235c7 
…6749)

Precaution detailed in googleapis#6748.
@noahdietz noahdietz mentioned this issue Sep 29, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 29, 2022
@noahdietz
chore(storage): fix retention_period type change (#6781)
4b55524 
Fixes #6748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahdietz noahdietz

Labels
api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(storage): fix retention_period type change noahdietz/google-cloud-go
1 participant
@noahdietz