feat(bigtable): add update table metadata support #6746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
kevinsi4508
reviewed
Sep 28, 2022
telpirion
requested changes
Sep 28, 2022
…6749) Precaution detailed in googleapis#6748.
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#911 Changes: feat(aiplatform): add model_source_info to Model in aiplatform v1beta1 model.proto PiperOrigin-RevId: 476411826 Source-Link: googleapis/googleapis@72f0faa docs(language): fix docstring formatting Committer: @parthea PiperOrigin-RevId: 476410563 Source-Link: googleapis/googleapis@7f579ee feat(aiplatform): add model_source_info to Model in aiplatform v1 model.proto PiperOrigin-RevId: 476193748 Source-Link: googleapis/googleapis@a7f3890 chore(retail): revert removal of LRO mixin PiperOrigin-RevId: 476177134 Source-Link: googleapis/googleapis@174b42d fix(dialogflow/cx): revert removal of LRO mixin PiperOrigin-RevId: 476177109 Source-Link: googleapis/googleapis@652c4c1 feat(iam): remove ListApplicablePolicies PiperOrigin-RevId: 475955031 Source-Link: googleapis/googleapis@65376f4 feat(bigquery/analyticshub): rename nodejs analyticshub library package name PiperOrigin-RevId: 475881872 Source-Link: googleapis/googleapis@8933d4b chore(dataplex): remove duplicated IAM mixin for Node.js library PiperOrigin-RevId: 475855448 Source-Link: googleapis/googleapis@b7c271c feat(dataproc): add support for Dataproc metric configuration Committer: @AkshatBhargava PiperOrigin-RevId: 475750057 Source-Link: googleapis/googleapis@30517fd chore(bigquery/storage): update gapic-generator-python-1.4.4 with unit tests generation fixes PiperOrigin-RevId: 475683078 Source-Link: googleapis/googleapis@df791ce feat(language): Add support for V1 and V2 classification models for the V1Beta2 API PiperOrigin-RevId: 475604619 Source-Link: googleapis/googleapis@044a15c feat(language): Add support for V1 and V2 classification models for the V1 API PiperOrigin-RevId: 475599241 Source-Link: googleapis/googleapis@05b99f9 feat(aiplatform): add timestamp_outside_retention_rows_count to ImportFeatureValuesResponse and ImportFeatureValuesOperationMetadata in aiplatform v1 featurestore_service.proto feat: add RemoveContextChildren rpc to aiplatform v1 metadata_service.proto feat: add order_by to ListArtifactsRequest, ListContextsRequest, and ListExecutionsRequest in aiplatform v1 metadata_service.proto PiperOrigin-RevId: 475580702 Source-Link: googleapis/googleapis@af65a19 feat(aiplatform): add timestamp_outside_retention_rows_count to ImportFeatureValuesResponse and ImportFeatureValuesOperationMetadata in aiplatform v1beta1 featurestore_service.proto feat: add RemoveContextChildren rpc to aiplatform v1beta1 metadata_service.proto feat: add order_by to ListArtifactsRequest, ListContextsRequest, and ListExecutionsRequest in aiplatform v1beta1 metadata_service.proto feat: add InputArtifact to RuntimeConfig in aiplatform v1beta1 pipeline_job.proto feat: add read_mask to ListPipelineJobsRequest in aiplatform v1beta1 pipeline_service.proto feat: add TransferLearningConfig in aiplatform v1beta1 study.proto PiperOrigin-RevId: 475580307 Source-Link: googleapis/googleapis@dbc83bd chore(dataform): update gapic-generator-python to 1.4.3 with test fixes PiperOrigin-RevId: 475399737 Source-Link: googleapis/googleapis@4c4a9a2 feat(asset): Add client library support for AssetService v1 SavedQuery APIs Committer: jeffreyai@ PiperOrigin-RevId: 475366952 Source-Link: googleapis/googleapis@7428dad
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#912
…pis#6695) This PR adds support for automatic retry of failed appends. Failures are evaluated both from the perspective of any receive errors getting the response, as well as any response that may be embedded in response from the service. Previous behavior was to simply re-attempt failures when issuing the append. This PR also adds a new WriterOption (`DisableWriteRetries(disable bool)`) to control this behavior (default is to have retries enabled). For users sensitive to write duplication, this PR also exposes a new TotalAttempts method on the AppendResult, which will indicate the total number of times this write was attempted. This also tries to clean up retries in general a bit more. The generated client will already retry unary RPCs, subject to the [service config](https://github.com/googleapis/googleapis/blob/master/google/cloud/bigquery/storage/v1/bigquerystorage_grpc_service_config.json) present when generating the storage API. We specifically clarify/introduce two additional kinds of retries above that: a unary retry and a stateless retry. The unary retry is used to (re)open the underlying bidi network connection which appends are sent upon, as we want to be resilient to reconnection. The unary retry is effectively stateful for the operation of reopening the connection, and thus uses a gax-based backoff that backs off with increasing intervals. The stateless retry is used when processing the responses returning from the backend on the bidi stream, where backing off incrementally doesn't make sense. Instead, we use a base backoff and jitter, and for cases where a more severe backoff is warranted (throughput exhaustion) we use a multiplication factor. The intent here is to provide backpressure which will eventually saturate the append queue and cause blocking/rejection of writes until the backlog recovers.
Adds retry config to grpcReader and grpcWriter types so that they can be propagated to operations as needed. Ensure that the configured values are used for all retry calls, and that UserProject is consistently passed through as well.
Add dual transport tests for HMAC keys and for PostPolicyV4. One PostPolicyV4 test creates a second client with custom key behavior. I split this test into two separate tests, one of which fails for gRPC. I left this as a skip for now since it will require some digging in the constructor creds logic to fix. I also cleaned up some layers of indirection around the various testConfig client methods, and now the multiTransportTest function can take client options to pass down to the client constructors which should make it easier to clean up some other tests which have custom client constructor logic.
…ogleapis#6761) Per guidance from backend team, include FailedPrecondition as part of the allowed retry.
telpirion
requested changes
Oct 5, 2022
telpirion
approved these changes
Oct 5, 2022
telpirion
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
yuhanpenggoogle
approved these changes
Oct 6, 2022
telpirion
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
auto-merge was automatically disabled
October 7, 2022 17:13
Head branch was pushed to by a user without write access
telpirion
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
This was referenced Nov 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeletionProtectionfield toTableConfandTableInfoUpdateTablefunction to change the value ofDeletionProtectionDeletionProtectioncan be updated throughUpdateTablemockTableAdminClockandsetupTableClientto support tests for Table admin APIsupdateTablecreateTablechanges to supportDeletionProtectionwill be added in the next pull request