perf(spanner): grab debug stack outside of lock (#11587)

Co-authored-by: rahul2393 <irahul@google.com>
googleapis · Feb 20, 2025 · 0ee82ff · 0ee82ff
1 parent 4b40201
commit 0ee82ff
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/spanner/session.go b/spanner/session.go
@@ -1103,11 +1103,11 @@ func (p *sessionPool) newSessionHandle(s *session) (sh *sessionHandle) {
 		return sh
 	}
 	if p.TrackSessionHandles || p.ActionOnInactiveTransaction == Warn || p.ActionOnInactiveTransaction == WarnAndClose || p.ActionOnInactiveTransaction == Close {
-		p.mu.Lock()
-		sh.trackedSessionHandle = p.trackedSessionHandles.PushBack(sh)
 		if p.TrackSessionHandles {
 			sh.stack = debug.Stack()
 		}
+		p.mu.Lock()
+		sh.trackedSessionHandle = p.trackedSessionHandles.PushBack(sh)
 		p.mu.Unlock()
 	}
 	return sh