feat: Add support for the Firebase Storage emulator #11535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
added
the
do not merge
|
Right, will have another pass through it myself and convert this into a PR to actually merge... |
jskeet
force-pushed
the
storage-emulator
branch
from
157043f to
1bf4d15
Compare
jskeet
changed the title
jskeet
removed
the
do not merge
jskeet
commented
Jan 19, 2024
amanda-tarafa
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite being large, much of this is copy-pasted from the gRPC emulator support (as this is the first REST-based emulator we've looked at). This is only a prototype at the moment, but it appears to work.
I'm looking for feedback about what I may be missing...
Towards #11522