Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GCS+gRPC): implement To/FromProto for HmacKeyMetadata #8926

Merged
merged 2 commits into from
May 9, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 9, 2022

Fixes #4213


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 6abed39a6b157e69a91036cea68ab7457af99b63

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #8926 (e32c789) into main (4a8f321) will increase coverage by 0.00%.
The diff coverage is 94.59%.

@@           Coverage Diff           @@
##             main    #8926   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files        1479     1481    +2     
  Lines      125259   125296   +37     
=======================================
+ Hits       116805   116841   +36     
- Misses       8454     8455    +1     
Impacted Files Coverage Δ
google/cloud/storage/hmac_key_metadata.h 100.00% <ø> (ø)
.../storage/internal/grpc_hmac_key_metadata_parser.cc 91.66% <91.66%> (ø)
...age/internal/grpc_hmac_key_metadata_parser_test.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/subscriber_connection_test.cc 97.91% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a8f321...e32c789. Read the comment docs.

@coryan coryan marked this pull request as ready for review May 9, 2022 18:08
@coryan coryan requested a review from a team as a code owner May 9, 2022 18:08
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: e32c7899037a610076e21233293b1810cf579e8e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan enabled auto-merge (squash) May 9, 2022 22:10
@coryan coryan merged commit 8cb8aef into googleapis:main May 9, 2022
@coryan coryan deleted the feat-GCS+gRPC-HmacKeyMetadata branch May 10, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ToProto/FromProto for storage::HmacKeyMetadata
3 participants