cleanup(storage): simplify ObjectReadStreambuf #6983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the implementation of `storage::internal::ObjectReadStreambuf`. The class had two different paths to get more data from the underlying `internal::ObjectReadSource`, this change makes all reads through the `xsgetn()` function. In addition, the class was sloppy with the hash validator, potentially using it after it was moved-from, luckily this was harmless, but no reason to keep doing so. I added some integration tests to cover corner cases that were only detected by accident in other tests.
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
googlebot
added
the
cla: yes
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6983 +/- ##
=======================================
Coverage 94.56% 94.57%
=======================================
Files 1298 1298
Lines 114599 114608 +9
=======================================
+ Hits 108371 108385 +14
+ Misses 6228 6223 -5
Continue to review full report at Codecov.
|
devjgm
approved these changes
Jul 14, 2021
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devjgm
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the implementation of
storage::internal::ObjectReadStreambuf.The class had two different paths to get more data from the underlying
internal::ObjectReadSource, this change makes all reads through thexsgetn()function.In addition, the class was sloppy with the hash validator, potentially
using it after it was moved-from, luckily this was harmless, but no
reason to keep doing so.
I added some integration tests to cover corner cases that were only
detected by accident in other tests.
Part of the work for #4156 and #4157
This change is