-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required dependencies so genrule can access CC and CC_FLAGS. #2358
Conversation
Your test infrastructure seems to be using Bazel 0.23.2, not the recently released 0.24.0, which this change requires.
Can I assist with updating that? |
Codecov Report
@@ Coverage Diff @@
## master #2358 +/- ##
=======================================
Coverage 92.57% 92.57%
=======================================
Files 307 307
Lines 19252 19252
=======================================
Hits 17822 17822
Misses 1430 1430 Continue to review full report at Codecov.
|
Sumitted #2360. CI should work now. |
Actually I think @katre may need to rebase. Travis (at least) merges the PR against |
Pushed a rebased commit. Thanks for the assistance. |
Thanks for updating the test runner. Let me know if there is anything further. |
TensorFlow probably needs a new release from google-cloud-cpp for fixing this incompatibility. @devjgm Is it possible to have a patch release for 0.7.0 or can TF refer to a specific commit of this repo? |
I'm going to do a new release of this project in the next day or two. Probably Thursday of this week. Is that OK? |
Sounds good, thank you! |
This change is due to bazelbuild/bazel#6867.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)