Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required dependencies so genrule can access CC and CC_FLAGS. #2358

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Add required dependencies so genrule can access CC and CC_FLAGS. #2358

merged 1 commit into from
Mar 28, 2019

Conversation

katre
Copy link
Contributor

@katre katre commented Mar 28, 2019

This change is due to bazelbuild/bazel#6867.

This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2019
@coryan coryan added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 28, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 28, 2019
@katre
Copy link
Contributor Author

katre commented Mar 28, 2019

Your test infrastructure seems to be using Bazel 0.23.2, not the recently released 0.24.0, which this change requires.

bazel-0.23.2-installer-linux-x86_64.sh: OK

Can I assist with updating that?

@devjgm devjgm self-requested a review March 28, 2019 14:32
@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #2358 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2358   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files         307      307           
  Lines       19252    19252           
=======================================
  Hits        17822    17822           
  Misses       1430     1430

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a7827e...13724a8. Read the comment docs.

@devjgm
Copy link
Contributor

devjgm commented Mar 28, 2019

Sumitted #2360. CI should work now.

@coryan
Copy link
Contributor

coryan commented Mar 28, 2019

Actually I think @katre may need to rebase. Travis (at least) merges the PR against master at the time the PR was created. New changes are not picked up automatically.

@katre
Copy link
Contributor Author

katre commented Mar 28, 2019

Pushed a rebased commit. Thanks for the assistance.

@coryan coryan added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 28, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 28, 2019
@katre
Copy link
Contributor Author

katre commented Mar 28, 2019

Thanks for updating the test runner. Let me know if there is anything further.

@devjgm devjgm merged commit 92ae48e into googleapis:master Mar 28, 2019
@katre katre deleted the fix-cc-flags branch March 28, 2019 18:04
@meteorcloudy
Copy link

TensorFlow probably needs a new release from google-cloud-cpp for fixing this incompatibility. @devjgm Is it possible to have a patch release for 0.7.0 or can TF refer to a specific commit of this repo?

https://github.com/tensorflow/tensorflow/blob/850e30a5cbba72e7ade103054159d7f6719d59a9/tensorflow/workspace.bzl#L200

@devjgm
Copy link
Contributor

devjgm commented Apr 2, 2019

I'm going to do a new release of this project in the next day or two. Probably Thursday of this week. Is that OK?

@meteorcloudy
Copy link

Sounds good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants