Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(gcb): make multiple Kaniko attempts #14222

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 10, 2024

Instead of retrying inside Kaniko, just retry the Kaniko calls. Related to #6438


This change is Reviewable

@coryan coryan marked this pull request as ready for review May 10, 2024 19:02
@coryan coryan requested a review from a team as a code owner May 10, 2024 19:02
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.79%. Comparing base (bcfae5d) to head (5ee4eb4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14222      +/-   ##
==========================================
- Coverage   93.79%   93.79%   -0.01%     
==========================================
  Files        2295     2295              
  Lines      202974   202974              
==========================================
- Hits       190385   190377       -8     
- Misses      12589    12597       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe.

@coryan coryan enabled auto-merge (squash) May 10, 2024 19:19
@coryan coryan merged commit 50a9385 into googleapis:main May 10, 2024
63 checks passed
@coryan coryan deleted the ci-gcb-retry-on-kaniko-failures-take-42 branch May 20, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants