feat(storage): offer mock client without decorators #11697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11697 +/- ##
=======================================
Coverage 83.03% 83.03%
=======================================
Files 1826 1827 +1
Lines 164702 164704 +2
=======================================
+ Hits 136758 136762 +4
+ Misses 27944 27942 -2
☔ View full report in Codecov by Sentry. |
coryan
approved these changes
May 22, 2023
| * Create a client configured to use the given mock. | ||
| * | ||
| * Unless you specifically need to mock the behavior of retries, prefer | ||
| * #google::cloud::storage::testing::UndecoratedClientFromMock |
There was a problem hiding this comment.
Typically if you say UndecoratedClientFromMock() (note the parenthesis) Doxygen will automatically link the function.
dbolduc
force-pushed
the
storage-undecorated-mock-client
branch
from
15db816 to
0eb2ba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by #11613
This allows customers to mock a single response from a
RawClient(instead of N responses in the case of transient errors).Prefer the
UndecoratedClientFromMock>ClientFromMockin the public samples. I did not update our unit tests.I did not think about whether extra effort is needed to make the install work.
This change is