Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

ci: use gRPC-1.26.x to workaround a known bug #1232

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Feb 3, 2020

Workaround grpc/grpc#21280 by compiling against a specific commit
(without a tag) of the v1.26.x gRPC branch.


This change is Reviewable

Workaround grpc/grpc#21280 by compiling against a specific commit
(without a tag) of the v1.26.x gRPC branch.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2020
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #1232 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1232      +/-   ##
==========================================
- Coverage   94.97%   94.94%   -0.03%     
==========================================
  Files         184      184              
  Lines       13820    13821       +1     
==========================================
- Hits        13125    13122       -3     
- Misses        695      699       +4
Impacted Files Coverage Δ
...loud/spanner/internal/partial_result_set_resume.cc 90.9% <0%> (-4.55%) ⬇️
...on_tests/rpc_failure_threshold_integration_test.cc 85.55% <0%> (-2.23%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 81.57% <0%> (-1.76%) ⬇️
google/cloud/spanner/internal/spanner_stub.cc 69.56% <0%> (-1.09%) ⬇️
google/cloud/spanner/client.cc 96.55% <0%> (-0.87%) ⬇️
...anner/integration_tests/client_integration_test.cc 98.47% <0%> (-0.01%) ⬇️
google/cloud/spanner/keys.h 100% <0%> (ø) ⬆️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 92.36% <0%> (ø) ⬆️
google/cloud/spanner/transaction.h 100% <0%> (ø) ⬆️
google/cloud/spanner/samples/samples.cc 88.04% <0%> (+0.18%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07fd0d...a8432e6. Read the comment docs.

@devbww devbww marked this pull request as ready for review February 3, 2020 07:31
@devbww devbww requested a review from coryan February 3, 2020 07:31
@devbww
Copy link
Contributor Author

devbww commented Feb 3, 2020

It looks like you may have approved the google_cloud_cpp version twice, instead of hitting this one?

@devbww devbww merged commit 21c93a8 into googleapis:master Feb 3, 2020
@devbww devbww deleted the workaround-grpc-issue-21280 branch February 3, 2020 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants