Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename CLOCK_SKEW and separate client/server user case #863

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

arithmetic1728
Copy link
Contributor

  1. Rename _helper.CLOCK_SKEW to _helper.REFRESH_THRESHOLD. This value is for client to decide when to refresh a token.
  2. Add a clock_skew_in_seconds keyword parameter (default value is 0) to jwt.decode, and remove the hard coded _helper.CLOCK_SKEW in the logic. The reason is jwt.decode is for server usage to validate iat/exp value. We should leave the clock skew to the server since this is server specific.

@arithmetic1728 arithmetic1728 requested review from silvolu and a team as code owners September 8, 2021 06:35
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2021
google/auth/_helpers.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants