Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop direct pyasn1 dependency #230

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Drop direct pyasn1 dependency #230

merged 1 commit into from
Dec 15, 2017

Conversation

theacodes
Copy link
Contributor

@theacodes theacodes commented Dec 15, 2017 •
edited
Loading

Instead, rely on pyasn1-modules to pull the appropriate version.

Drop direct pyasn1 dependency
ab71a28 
Instead, rely on pyans1-modules to pull the appropriate version.
@theacodes theacodes requested a review from dhermes December 15, 2017 17:56
dhermes
dhermes approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theacodes
Copy link
Contributor Author

Merging despite lint, which I guess I should just turn off.

@theacodes theacodes merged commit 945c357 into master Dec 15, 2017
@theacodes theacodes deleted the jonparrott-patch-1 branch December 15, 2017 18:00
@dhermes
Copy link
Contributor

dhermes commented Dec 15, 2017

which I guess I should just turn off

Boo

@theacodes
Copy link
Contributor Author

Just our franken-pylint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theacodes @dhermes