Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix App Engine's expiration calculation #197

Merged
merged 2 commits into from
Sep 12, 2017
Merged

Conversation

theacodes
Copy link
Contributor

@dhermes
Copy link
Contributor

dhermes commented Sep 12, 2017

LGTM, though WDYT about adding a script here that will deploy a new GAE app and run unit tests there (with results available via curl, e.g.)

@theacodes
Copy link
Contributor Author

LGTM, though WDYT about adding a script here that will deploy a new GAE app and run unit tests there (with results available via curl, e.g.)

We have one in system_tests, it just doesn't do any introspection on the token or expiry - it just makes an authenticated request and verifies it works.

@theacodes theacodes merged commit 1cba0f8 into master Sep 12, 2017
@theacodes theacodes deleted the fix-app-engine-expiry branch September 12, 2017 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants